dynalite icon indicating copy to clipboard operation
dynalite copied to clipboard

Add basic logging that can be enabled with --verbose

Open pifantastic opened this issue 10 years ago • 3 comments

...ption.

pifantastic avatar Jul 31 '14 00:07 pifantastic

Hey! Any chance of getting this merged?

pifantastic avatar Sep 30 '14 17:09 pifantastic

Hey there - sorry I've been sitting on it for so long.

I'm actually not a huge fan of winston - we used it for a while at my last job and it didn't hold up too well. Although things have probably changed since then. We ended up using bunyan which we much preferred.

In this case, I'm not even sure if adding another large dependency (and all its sub-dependencies) is even necessary. console.log and console.error might suffice for this just fine.

mhart avatar Sep 30 '14 17:09 mhart

@mhart no worries, thanks for taking a look. Honestly I chose winston because i was being lazy and I wanted the logs to be "pretty". I can understand you not wanting to add a dependency for something simple. I'll find some time to swap it out.

pifantastic avatar Sep 30 '14 17:09 pifantastic

@pifantastic I know it's only like 8 years later, but if you'd like to update this to use console.error, I'd be happy to merge!

ryanblock avatar Aug 30 '23 01:08 ryanblock

Merging this got a bit out of hand for such a small change, so I'll replicate the spirit of it (sans winston) and give some props in the changelog to you, @pifantastic – thank you!

ryanblock avatar Aug 30 '23 21:08 ryanblock