archi icon indicating copy to clipboard operation
archi copied to clipboard

Linebreak behaviour changed in Archi 4.10

Open jusla opened this issue 3 years ago • 4 comments

Version of Archi

Archi 4.10

Archi Plug-ins

coArchi 0.8.4

Operating System

Windows 10

Expected Behaviour

Line breaks do not occur between ) and . characters.

Line break opportunities are not available next to a right double quote character (”) at least in notes.

Phrases in element names separated with slashes are split in a smart way (if the part after the slash fits entirely on the next line, the linebreak occurs after the slash, not mid-word). For example FirstPart/LastPart was split FirstPart/ LastPart

Actual Behaviour

Line breaks occur in these instances.

Example 1:

word) .

Example 2:

Some text that is before a part ” quoted with right double quotes”

(NOTE: Normal straight quotes apparently still work fine in Archi 4.10.)

Example 3: FirstPart/La stPart

This did not happen with Archi 4.9.

Steps to Reproduce the Behaviour

  1. Create an element in an ArchiMate view.
  2. Write e.g. "(texttextexttext)." in the element.
  3. Scale the element size down horizontally (holding down Alt if necessary) and observe where the line breaks.

PS. Thanks for Archi, it's great!

jusla avatar Sep 21 '22 12:09 jusla

Thanks for the report. This is a regression introduced here:

https://github.com/archimatetool/archi/commit/d64e3009ea188be96381df039be328f138f4fa5d

I will revert this for Archi 4.10.1

Phillipus avatar Sep 21 '22 13:09 Phillipus

This is how line breaks appear using com.ibm.icu.text.BreakIterator:

ibm

And using java.text.BreakIterator:

java

Phillipus avatar Sep 21 '22 13:09 Phillipus

Archi 4.10 replaced the com.ibm.icu.text.BreakIterator class with java.text.BreakIterator. This was done because the com.ibm.icu package is being removed from Eclipse itself. I can ship com.ibm.icu with Archi if necessary. It's a shame as I was trying to remove that dependency. Seems the most serious change is when there is a / in words.

Phillipus avatar Sep 21 '22 17:09 Phillipus

See also:

https://github.com/eclipse/gef-classic/issues/116 https://github.com/eclipse/gef-classic/issues/289

Phillipus avatar Jul 02 '24 09:07 Phillipus