mapextrackt icon indicating copy to clipboard operation
mapextrackt copied to clipboard

Question: Is it intentional to not divide by the max-min difference when normalizing layer?

Open neoglez opened this issue 2 years ago • 2 comments

Thanks for the great library.

When setting the image, one options is to normalize the layer for viewing (parameter normalize_layer), if normalize_layer=False all features (independently of the others in the same layer) are normalized using min-max feature scaling. When normalize_layer=True, one would expect the layer to be normalized across all features using the same strategy, namely min-max feature scaling. However, the denominator doesn't contain the difference max-min but only max. Is this intentioned? If yes, why?

neoglez avatar Aug 18 '22 15:08 neoglez

That is not intentional as far as I am aware and most likely a bug. Why not submit a pull for a fix & I will review and push to master?

lewis-morris avatar Sep 03 '22 11:09 lewis-morris

This was really just a toy project that I made when experimenting with PyTorch, I haven't given it much thought since I made it.

Any improvements or issues feel free to throw them over

lewis-morris avatar Sep 03 '22 11:09 lewis-morris