tasty-imitation-keyboard icon indicating copy to clipboard operation
tasty-imitation-keyboard copied to clipboard

Performance Improvements

Open archagon opened this issue 10 years ago • 9 comments

  • [ ] memoize geometry calculations for key shapes (probably inconsequential despite repeated work)
  • [x] lazy load settings
  • [x] reuse keys between pages
  • [ ] share backing stores between CALayers for identically-sized keys
  • [ ] instead of having individual key views, draw them all manually in the view controller's view; will decide if/when incorporating illyabusigin/CYRKeyboardButton

archagon avatar Nov 17 '14 22:11 archagon

Performance is pretty good now. Not sure if further optimizations are needed.

archagon avatar Dec 23 '14 18:12 archagon

Yes but still bit lagging on iPad for example. You can feel it when keyboard appears or you change orientation as it draws background 1st then keyboard is visible. Actually the same thing happening for iPhone too but as it is drawing fast enough you can not mention it.

pirrate avatar Dec 23 '14 18:12 pirrate

@archagon You can edit your initial comment like this to make it easier to track these changes

  • [x] memoize geometry calculations for key shapes
  • [x] lazy load settings
  • [ ] reuse keys between pages
  • [ ] share backing stores between CALayers for identically-sized keys
  • [ ] Instead of having individual key views, draw them all manually in the view controller's view.

tkersey avatar Dec 23 '14 18:12 tkersey

draws background 1st then keyboard is visible

This happens with other 3rd party keyboards too. (Or at least it did in the past.)

iPad isn't really a priority right now, so as long as it doesn't crash, I'm OK with leaving it as-is for the time being.

@tkersey that's pretty cool, but will everyone be able to check the boxes?

archagon avatar Dec 23 '14 18:12 archagon

@archagon I'm not sure about that. I can check the ones in my comment but not sure if only you can or if others. Add one to your initial comment and I'll attempt to check it.

tkersey avatar Dec 23 '14 19:12 tkersey

  • [x] this
  • [x] is
  • [ ] a
  • [ ] test

archagon avatar Dec 23 '14 19:12 archagon

@archagon Nope. I can't check them.

tkersey avatar Dec 23 '14 19:12 tkersey

Ha, but I can check yours. I have the powah.

archagon avatar Dec 23 '14 19:12 archagon

:boom:

tkersey avatar Dec 23 '14 19:12 tkersey