sensible-side-buttons icon indicating copy to clipboard operation
sensible-side-buttons copied to clipboard

Published 20 hours ago • verified publisher icon archagon

Stopped working with Chrome

Open jofbe opened this issue 3 years ago • 7 comments

Hello!

Thank you for this great tool, I'm using it for years now. Just recently though, it stopped working in chrome, while keep working in firefox, safari, and other apps.

Do you have any advice?

Chrome: 90.0.4430.93 OS: 10.15.7

Thanks!

jofbe avatar May 10 '21 08:05 jofbe

Stops working for me about once a day in Chrome, if I restart Chrome it works again.

danielktaylor avatar May 11 '21 19:05 danielktaylor

I can confirm that when it doesn't work in Chrome (until you restart chrome), it still works in Safari.

danielktaylor avatar May 12 '21 19:05 danielktaylor

I think might have to do with a conflict between SensibleSideButtons and Chrome - the navigation in Chrome seems to work again if SensibleSideButtons is closed. I've created a branch based on @bojanin's work which disables the app's functionality within Chrome specifically and navigation when using the side buttons still works as expected.

Desousak avatar May 16 '21 22:05 Desousak

If there's a way to unhook this from Chrome only, that would be awesome.

ben-xo avatar May 20 '21 08:05 ben-xo

I think might have to do with a conflict between SensibleSideButtons and Chrome - the navigation in Chrome seems to work again if SensibleSideButtons is closed. I've created a branch based on @bojanin's work which disables the app's functionality within Chrome specifically and navigation when using the side buttons still works as expected.

Nice! Any chance you could turn that into a proper pull request?

What's the reason for adding the nil at the end of the list?

ben-xo avatar May 20 '21 08:05 ben-xo

I think might have to do with a conflict between SensibleSideButtons and Chrome - the navigation in Chrome seems to work again if SensibleSideButtons is closed. I've created a branch based on @bojanin's work which disables the app's functionality within Chrome specifically and navigation when using the side buttons still works as expected.

Nice! Any chance you could turn that into a proper pull request?

What's the reason for adding the nil at the end of the list?

I plan to! Before I do, I wanted to implement some UI to allow for adding/removing new applications onto the block list.

As for the nil, I mainly followed Apple's documentation for the arrayWithObjects method. I'm fairly new to macOS development, so I can't say why it's needed in particular, haha.

Desousak avatar May 20 '21 19:05 Desousak

Please also add "com.microsoft.edgemac" to the list.

varargs in Objective-C are usually nil terminated, so it is required at the end of arrayWithObjects

Cyberbeni avatar Nov 11 '21 09:11 Cyberbeni