Aegisub icon indicating copy to clipboard operation
Aegisub copied to clipboard

Update Korean translation

Open Hackjjang opened this issue 1 year ago • 6 comments

image

I'd like to contribute to making the tool more accessible to people with Korean accessibility.

Hackjjang avatar Aug 18 '23 08:08 Hackjjang

Is there a specific reason why it won't merge?

Hackjjang avatar Sep 20 '23 00:09 Hackjjang

I'm very hesitant about merging PRs updating translations to languages I don't speak, since I can't check myself if they are correct. They're also a bit out of scope for this fork, which mostly collects bugfixes and new features - translation updates would fit better in a more central place like upstream.

I don't mind this PR being open here - that way people can use it for whatever they might need it for - but for now I can't really merge it, sorry.

arch1t3cht avatar Sep 22 '23 00:09 arch1t3cht

I think it would be better to merge it and get some feedback. I've been doing Korean localisation for PCSX2, DuckStation, Cemu, etc. I've also done subtitling in the past, and I've been getting feedback on my translations through my blog (although I've only gotten feedback once...).

Hackjjang avatar Sep 22 '23 13:09 Hackjjang

If the reason is that the existing translation has a lot of mistranslations and untranslated parts, and you can't check the translation problem, it's better to delete it except for the languages you can manage.

Hackjjang avatar Oct 03 '23 19:10 Hackjjang

I wouldn't have translated it if I didn't think it would be reflected like this... I've done something wrong...

Hackjjang avatar Oct 16 '23 06:10 Hackjjang

Why not approve it first and see what users think?

Hackjjang avatar Nov 28 '23 23:11 Hackjjang