Roger Tuan

Results 42 comments of Roger Tuan

@stefanoverna PR here for now: https://github.com/datocms/react-datocms/pull/115 Mux upstream released mux-player@v3 not too long ago (we're still on v2). Maybe for the next major release, we can hard remove one of...

Hi @jericho-forte, What are the inputs to `content` and `translation` here? It'd be easiest if you could please make a reproduction of this in a working repo (like a codesandbox/codepen...

Potential PR: https://github.com/reduxjs/redux-devtools/pull/1828

I'm so sorry, we are closing this for now due to CI/CD issues. We are probably going to sunset this plugin :( Please see https://github.com/datocms/gatsby-source-datocms/pull/233#issuecomment-2161841847 (in the other PR) for...

Hi @sarah11918, I did as you asked, and _both_ the component and layout were able to modify the headers. I also updated the Stackblitz: https://stackblitz.com/~/github.com/arcataroger/astro-header-modification-in-layout In `index.astro`, the `Welcome` component...

I also tried it with individual `Astro.response.headers.set()` calls, not just the `.append()`. Same result: ```astro Astro.response.headers.set('header-source-index', 'true') // or header-source-component, header-source-layout ``` Result: ![Image](https://github.com/user-attachments/assets/4239449d-ce3c-4bb4-83e4-abab3b112ae7)

Ah, gotcha @sarah11918, sorry I misunderstood! But it's still the same behavior: ![Image](https://github.com/user-attachments/assets/445dbc5e-6143-467a-b6f6-2b434ce77c60) ```mdx // index.astro --- import Welcome from "../components/Welcome.astro"; import Layout from "../layouts/Layout.astro"; import FirstComponent from "../components/FirstComponent.astro"; Astro.response.headers.append("header-sources",...

Oh! Hey, this is probably relevant: The documented behavior is **correct** in the default Astro SSG mode (i.e., no headers are modified/added): ![Image](https://github.com/user-attachments/assets/09c81330-13c3-44b4-be2b-c489a7fcdb5f) Where it does NOT apply (and where...

Thus, in terms of the docs, I don't know: - Why this warning is connected on the on-demand rendering page (that mostly talks about SSR), instead of on the SSG...

Thanks, @sarah11918! Hope they can clarify what is intentional or not, and update the docs accordingly :) One last point: I should point out that in the SSG example, it...