Maël Nison

Results 627 comments of Maël Nison

Yep, using an explicit registration service is a solution too. However, I think that the less setup code required, the better. In this case, it could be possible to use...

Firefox returns null when calling `getComputedStyle` on a node that is not displayed on screen.

A workaround is to point the `overlay.module` setting to something like this following: ```ts export * from '@pmmmwh/react-refresh-webpack-plugin/overlay'; import {handleRuntimeError as origHandleRuntimeError} from '@pmmmwh/react-refresh-webpack-plugin/overlay'; const symbol = Symbol(`overlay`); globalThis.preventOverlay =...

It seems very reasonable 👍 My only nitpick: > If possible, filter out browser-generated network errors and never show them in a dialog. I'm not sure that all client libraries...

Thanks for reminding me, it should be all good now! The test was failing because of a typo made during the last merge conflict resolution.

Thanks @mischnic ! Thanks @Artoria2e5 !

It seems difficult to do in a way that won't result in other edge cases. For that to work, we'd need to store the links somewhere, so we can restore...

I'm still not convinced this is a good idea: - It prevents using hashes to ensure the version is the expected one - It gives users a false sense of...

Mostly time. On my side I'd like to add signing support to Yarn before asking for it to become stable, but I'm currently focusing on another Node PR. Perhaps in...

What are you referring to? That doesn't ring a bell.