framework icon indicating copy to clipboard operation
framework copied to clipboard

Remove duplicated build system in alien/ArcaneInterface

Open guignont opened this issue 1 year ago • 6 comments

A proposal to remove buildsystem part in Alien ArcaneInterface

guignont avatar Dec 02 '24 12:12 guignont

I think it is a good idea to remove duplication. So now it uses the configuration from app_buildsystem_tools ?

Yes

guignont avatar Dec 03 '24 08:12 guignont

@grospelliergilles It's seem that Ubuntu used for Codecov test lacks Mono and DotNet. Is it possible to install them ?

guignont avatar Dec 06 '24 10:12 guignont

@grospelliergilles It's seem that Ubuntu used for Codecov test lacks Mono and DotNet. Is it possible to install them ?

we no longer support mono but dotnet is present in the image used by codecov. You can see in this action for example; https://github.com/arcaneframework/framework/actions/runs/12191621972/job/34010826688. The tests used by dotnet contains the string corecrl in their name.

If needed we can install mono. @stdcm may know if it is really needed. Maybe it is possible to remove this find_package().

grospelliergilles avatar Dec 06 '24 11:12 grospelliergilles

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.30%. Comparing base (8a25326) to head (34fa47e). Report is 3 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
- Coverage   70.31%   70.30%   -0.01%     
==========================================
  Files        2275     2275              
  Lines      163815   163813       -2     
  Branches    18871    18869       -2     
==========================================
- Hits       115183   115175       -8     
- Misses      41799    41801       +2     
- Partials     6833     6837       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 06 '24 13:12 codecov[bot]

@stdcm Can you describe framework build and install procedure for use with ArcaneDemo because my ArcaneDemo build has no problem finding AlienLegacyPlugins ?

guignont avatar Jan 02 '25 15:01 guignont

I just made the following test in ArcaneDemo replacing build-system with the one in this branch. The configuration with cmake works fine but when compiling there is errors in c++ generated files:

In file included from /work/guignont/work/ArcaneDemo/cmake-build-debug-arcane3user_gimkl2018b_localarcane/ArcaneDemo/axl/RootTester_axl.h:507:0, from /work/guignont/work/ArcaneDemo/common/ArcGeoSim/src/ArcGeoSim/Tests/ServiceTesters/StrongOptionsTester/RootTesterService.h:10, from /work/guignont/work/ArcaneDemo/common/ArcGeoSim/src/ArcGeoSim/Tests/ServiceTesters/StrongOptionsTester/RootTesterService.cc:6: /work/guignont/work/ArcaneDemo/cmake-build-debug-arcane3user_gimkl2018b_localarcane/ArcaneDemo/axl/RootTester_CaseOptionsT.h:133:65: error: « ; » attendu à la fin de la déclaration du membre Arcane::ConstArrayViewTypesStrongOptionsTester::eSimpleEnum simpleEnum4 const ^~~~~~~~~~~ /work/guignont/work/ArcaneDemo/cmake-build-debug-arcane3user_gimkl2018b_localarcane/ArcaneDemo/axl/RootTester_CaseOptionsT.h:134:3: error: expected unqualified-id before « { » token { ^ /work/guignont/work/ArcaneDemo/cmake-build-debug-arcane3user_gimkl2018b_localarcane/ArcaneDemo/axl/RootTester_CaseOptionsT.h:137:65: error: « ; » attendu à la fin de la déclaration du membre Arcane::ConstArrayViewTypesStrongOptionsTester::eSimpleEnum simpleEnum5 const ^~~~~~~~~~~ /work/guignont/work/ArcaneDemo/cmake-build-debug-arcane3user_gimkl2018b_localarcane/ArcaneDemo/axl/RootTester_CaseOptionsT.h:138:3: error: expected unqualified-id before « { » token {

Anyway with a manual correction the build is ok.

guignont avatar Jan 10 '25 10:01 guignont