framework icon indicating copy to clipboard operation
framework copied to clipboard

Finalize porting updating materials cells on accelerator

Open grospelliergilles opened this issue 1 year ago • 2 comments

We need to complete the following tasks:

Top priority

  • [x] Remove remaining memory transfers between Host and Accelerator
  • [ ] Keep list of memory holes in ConstituentConnectivityList when adding cells
  • [ ] Keep list of memory holes in MeshMaterialVariableIndexer::endUpdateAdd()
  • [x] Do not copy on Host the list of added/removed cells in MeshMaterialModifier
  • [x] Update ItemGroup associated to a constituent using accelerator API

Priority 2

  • [ ] Only update modified cells in AllEnvData::recomputeIncremental()

grospelliergilles avatar Mar 13 '24 10:03 grospelliergilles

@grospelliergilles , you did a good job and I agree with the optimizations you gave.

In addition, is it possible to port in arcane/src/arcane/materials/AllCellToAllEnvCellConverter.cc :

  • https://github.com/arcaneframework/framework/blob/cbb55d539f7ce47ddb0a9f2215ebf7b885f0169f/arcane/src/arcane/materials/AllCellToAllEnvCellConverter.cc#L63
  • https://github.com/arcaneframework/framework/blob/cbb55d539f7ce47ddb0a9f2215ebf7b885f0169f/arcane/src/arcane/materials/AllCellToAllEnvCellConverter.cc#L83
  • https://github.com/arcaneframework/framework/blob/cbb55d539f7ce47ddb0a9f2215ebf7b885f0169f/arcane/src/arcane/materials/AllCellToAllEnvCellConverter.cc#L128

These methods are called when enableCellToAllEnvCellForRunCommand() is enable like in the real code and soon in Mahyco.

DavidDureau avatar Mar 13 '24 16:03 DavidDureau

Yes I will look at that. But when all will be finished I think the class AllCellToAllEnvCellConverter will no longer be needed. I think now all the data are available from device.

grospelliergilles avatar Mar 13 '24 16:03 grospelliergilles