Feature: Add Search Bar to Navigation Component

[adarsh-jha-dev]

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This PR introduces a new feature to the Navigation component, adding a search bar that allows users to search for and filter conversations based on their names.

• Why was this change needed? (You can also link to an open issue here) The addition of a search bar was needed to improve the user experience and make it easier for users to find specific conversations within the Navigation component.

• Other information:

• The search bar allows users to enter search queries and filters conversations accordingly.

• Conversations are now dynamically filtered based on the search query.

• The feature enhances usability, especially in cases where users have a large number of conversations.

[vercel[bot]]

@adarsh-jha-dev is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-gpt	❌ Failed (Inspect)			Nov 3, 2023 2:45pm
nextra-docsgpt	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 3, 2023 2:45pm

[codecov[bot]]

Codecov Report

Merging #705 (b5437d0) into main (2d20208) will not change coverage. Report is 2 commits behind head on main. The diff coverage is n/a.

:exclamation: Current head b5437d0 differs from pull request most recent head 4ce218d. Consider uploading reports for the commit 4ce218d to get more accurate results

@@           Coverage Diff           @@
##             main     #705   +/-   ##
=======================================
  Coverage   19.69%   19.69%           
=======================================
  Files          62       62           
  Lines        2844     2844           
=======================================
  Hits          560      560           
  Misses       2284     2284           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[dartpain]

Thank you so much. Just two things:

1. Can you send the screenshot so we can check how it looks
2. There is a build error

src/Navigation.tsx(173,33): error TS18047: 'conversations' is possibly 'null'.

Error: Command "npm run build" exited with 2

[adarsh-jha-dev]

Thank you so much. Just two things:

1. Can you send the screenshot so we can check how it looks
2. There is a build error

src/Navigation.tsx(173,33): error TS18047: 'conversations' is possibly 'null'.

Error: Command "npm run build" exited with 2

I have tried to resolve that build error, could you please check that if the error is still there?

[dartpain]

Thank you, looks like its working, but desing wise its just on top of the page

@tenokami maybe we can put search on top of the sidebar or something? how should we make it look?

[adarsh-jha-dev]

Thank you, looks like its working, but desing wise its just on top of the page

@tenokami maybe we can put search on top of the sidebar or something? how should we make it look?

Thanks for considering, that was the problem i was unable to provide you the screenshot, i was worrying about the same, how should i make it look.

[dartpain]

There is an update available please sync with the latest version and checkout the design here to see how to integrate search https://www.figma.com/file/OXLtrl1EAy885to6S69554/DocsGPT?type=design&node-id=0-1&mode=design

eg Thank you!

[dartpain]

It failed to build, here is the error trace

src/Navigation.tsx(260,11): error TS2657: JSX expressions must have one parent element.

Error: Command "npm run build" exited with 2

[adarsh-jha-dev]

@Alex , Really sorry for that build error, I will correct each and every build error as well as make that front-end design by evening. Thank you.

On Tue, Oct 31, 2023, 06:44 Alex @.***> wrote:

It failed to build, here is the error trace src/Navigation.tsx(260,11): error TS2657: JSX expressions must have one parent element.

Error: Command "npm run build" exited with 2

— Reply to this email directly, view it on GitHub https://github.com/arc53/DocsGPT/pull/705#issuecomment-1786281307, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7RVAC4SEIEFXWATDGGOMSTYCBGGFAVCNFSM6AAAAAA6QO57NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBWGI4DCMZQG4 . You are receiving this because you were mentioned.Message ID: @.***>

[adarsh-jha-dev]

Hey @dartpain , I have made some changes , let me know if they are relevant or they need some modifications (i guess it should work now)

[dartpain]

There is another build error. here is the error trace:

 

Error: Command "npm run build" exited with 2

[adarsh-jha-dev]

There is another build error. here is the error trace:

 

Error: Command "npm run build" exited with 2

I think you missed to include the error trace

[adarsh-jha-dev]

There is another build error. here is the error trace:

 

Error: Command "npm run build" exited with 2

@dartpain , could you please give me the build error trace, I will fix it.

[dartpain]

Here is the trace

src/Navigation.tsx(291,11): error TS2657: JSX expressions must have one parent element. src/Navigation.tsx(427,7): error TS1005: ')' expected. Error: Command "npm run build" exited with 2

Error: Command "npm run build" exited with 2

[adarsh-jha-dev]

Here is the trace

src/Navigation.tsx(291,11): error TS2657: JSX expressions must have one parent element.

src/Navigation.tsx(427,7): error TS1005: ')' expected. Error: Command "npm run build" exited with 2 Error: Command "npm run build" exited with 2

Hey @dartpain , could you please let me know if the build error is still there ?

[dartpain]

Good, it built well Here is the way it looks Search bar should be right above new chat field

[adarsh-jha-dev]

@dartpain , I have done some changes , let me know if the search is placed correctly now

[dartpain]

This is the way it looks now

Also there are some left overs here:

Please try to stick to the design as mentioned here https://github.com/arc53/DocsGPT/pull/705#issuecomment-1786260635

Also it works as it is supposed to so functionality wise its good, its just the appearance

[adarsh-jha-dev]

This is the way it looks now

Also there are some left overs here:

Please try to stick to the design as mentioned here #705 (comment)

Also it works as it is supposed to so functionality wise its good, its just the appearance

To be honest , I am a bit weak in styling, that is why I am making so much of errors, thanks for co-operating. Will do it ASAP

[dartpain]

You have this error

src/Navigation.tsx(182,11): error TS17014: JSX fragment has no corresponding closing tag. src/Navigation.tsx(218,8): error TS1381: Unexpected token. Did you mean {'}'} or }? src/Navigation.tsx(474,7): error TS1003: Identifier expected. src/Navigation.tsx(475,4): error TS1005: '}' expected. src/Navigation.tsx(476,1): error TS1381: Unexpected token. Did you mean {'}'} or }? src/Navigation.tsx(477,1): error TS1005: '</' expected. Error: Command "npm run build" exited with 2

Error: Command "npm run build" exited with 2

[dartpain]

You have this error here

src/Navigation.tsx(182,11): error TS17014: JSX fragment has no corresponding closing tag.

12:45:28.710 | src/Navigation.tsx(192,15): error TS1005: '}' expected. 12:45:28.710 | src/Navigation.tsx(218,8): error TS1381: Unexpected token. Did you mean {'}'} or }? 12:45:28.710 | src/Navigation.tsx(476,7): error TS1003: Identifier expected. 12:45:28.710 | src/Navigation.tsx(477,4): error TS1005: '}' expected. 12:45:28.710 | src/Navigation.tsx(478,1): error TS1381: Unexpected token. Did you mean {'}'} or }? 12:45:28.711 | src/Navigation.tsx(479,1): error TS1005: '</' expected. 12:45:28.731 | Error: Command "npm run build" exited with 2

Thank you,

Does it work locally for you?

[adarsh-jha-dev]

You have this error here

src/Navigation.tsx(182,11): error TS17014: JSX fragment has no corresponding closing tag.

12:45:28.710 | src/Navigation.tsx(192,15): error TS1005: '}' expected. 12:45:28.710 | src/Navigation.tsx(218,8): error TS1381: Unexpected token. Did you mean {'}'} or }? 12:45:28.710 | src/Navigation.tsx(476,7): error TS1003: Identifier expected. 12:45:28.710 | src/Navigation.tsx(477,4): error TS1005: '}' expected. 12:45:28.710 | src/Navigation.tsx(478,1): error TS1381: Unexpected token. Did you mean {'}'} or }? 12:45:28.711 | src/Navigation.tsx(479,1): error TS1005: '</' expected. 12:45:28.731 | Error: Command "npm run build" exited with 2

Thank you,

Does it work locally for you?

Really sorry, wasn't working on it due to college exams, working on it now

[dartpain]

No worries, I just saw some commits and wanted to give some guidance. Take you time, good luck with the exams!