ArborX icon indicating copy to clipboard operation
ArborX copied to clipboard

Add DistributedTree Nearest query with callback

Open masterleinad opened this issue 2 years ago • 6 comments

The strategy here is to do a regular query that gets us the MPI ranks, and primitive indices for each query, send them back to the MPI rank owning the primitives, execute the callback, and send them back to the MPI rank owning the queries.

masterleinad avatar Sep 09 '22 19:09 masterleinad

This should work now replaying the found matches on the remote MPI rank and communicating the results back. Currently, I don't treat the default callback special to validate that this behaves as expected.

masterleinad avatar Sep 12 '22 19:09 masterleinad

This should be ready for inital review. As said before, the strategy here is to do a regular query that get's us the MPI ranks, and primitive indices for each query, send them back to the MPI rank owning the primitives, execute the callback, and send them back to the MPI rank owning the queries.

masterleinad avatar Sep 15 '22 15:09 masterleinad

I will still adopt some more tests to use the callback.

masterleinad avatar Sep 15 '22 15:09 masterleinad

@aprokop ping

masterleinad avatar Sep 22 '22 13:09 masterleinad

We need to support pure callbacks They would use mostly the same code, except the API would not have offset and output views, and they won't need the extra round of backward communication

That's the same as https://github.com/arborx/ArborX/pull/733, right?

masterleinad avatar Dec 16 '22 20:12 masterleinad

That's the same as #733, right?

No, that was for spatial queries. I need to think a bit about that one.

aprokop avatar Dec 16 '22 20:12 aprokop