ArborX icon indicating copy to clipboard operation
ArborX copied to clipboard
verified publisher icon arborx

Reorganize SVD

Open aprokop opened this issue 1 year ago • 1 comments

Main motivation is to provide the SVD utility (without the inverse) to be used in OBB. Additionally, this patch removes the symmetricPseudoInverseSVD function that is not being used. Given that the new functionality is to be used in more than just interpolation, the file was renamed.

aprokop avatar Aug 02 '24 17:08 aprokop

Did you only want to rename the file?

This patch:

  • Renames the file
  • Gets rid of the unused batch kernel to run pseudo-inverse SVD on multiple matrices
  • Moves out computing SVD out of the computing pseudo-inverse SVD so that one can now get the SVD result back

I expected you were going to move the functionality, possibly to KokkosExt or whatnot.

I consider it moved out of the interpolation to just Details. I have not considered KokkosExt, though one can argue it could belong to KokkosKernels.

aprokop avatar Aug 06 '24 20:08 aprokop