arbor icon indicating copy to clipboard operation
arbor copied to clipboard

Mechanism Unit Tests

Open thorstenhater opened this issue 3 years ago • 3 comments

Despite appearances, we have no actual unit tests on mechanisms, the file was disabled during a major re-work (I assume) of the mechanism infrastructure and addition of catalogues. This has allowed at least one bug to sneak under the radar.

I propose to add a new test set that covers (on CPU and GPU)

  • initialisation of storage
  • attribute tables
  • getting/setting attributes

The remaining functionality is part of the actual mechanism implemented by modcc and thus should be considered integration tests.

thorstenhater avatar Feb 25 '21 08:02 thorstenhater

This depends on #820 for consistency and foundation.

thorstenhater avatar Feb 25 '21 08:02 thorstenhater

Unit tests should cover, e.g., the implementation of a FUNCTION. The test infrastructure should be such that mechanisms and tests of parts of the mechanism can be easily added also for non-core developers, i.e., users that work on a custom mech.

schmitts avatar Mar 16 '21 12:03 schmitts

It's important that we verify the functional behaviour of mechanisms included with the Arbor library, and ensure that changes to e.g. modcc do not change the dynamical behaviour of these mechanisms. This could be a separate issue, or incorporated here.

halfflat avatar Mar 25 '21 13:03 halfflat