Simple-Comic icon indicating copy to clipboard operation
Simple-Comic copied to clipboard

Simple Comic no longer works in Catalina (10.15.1)

Open don1138 opened this issue 5 years ago • 10 comments

Nothing happens when I open a .cbz or .cbr file in Simple Comic.

File > Open, File > Open Recent, and View > Status Bar menus are available, but all others are disabled.

don1138 avatar Nov 07 '19 00:11 don1138

Same problem. What could be done?

ruotongli avatar Nov 07 '19 05:11 ruotongli

Here's the fix: in Session/TSSTPageView.m

/* In Catalina, (macOS 10.15) this method can get called so early that the frame is size 0. That causes an exception further down in UIView recenter when it checks its arguments. Exiting early fixes the problem. */

- (void)resizeView
 {
  firstPageRect = NSZeroRect;
  secondPageRect = NSZeroRect;
  NSRect visibleRect = [[self enclosingScrollView] documentVisibleRect];
  NSRect frameRect = [self frame];
  if (frameRect.size.width <= 0 || frameRect.size.height <= 0) {  // <- add these 3 lines.
    return;
  }

DavidPhillipOster avatar Nov 12 '19 05:11 DavidPhillipOster

For us plebeians, would any good samaritans re-upload a binary?

peirantan avatar Nov 13 '19 21:11 peirantan

I applied the change and it's working! Thanks DavidPhillipOster!

IDK if this is a bug or how it always worked, but the window size changes depending on the size of the page being viewed. But hey – as long as I can view books, I'm good.

Here's a link to the binary I compiled: https://drive.google.com/open?id=1yqBQhZwzN-FUYLfisKD27q03CoTqau0D

Enjoy!

don1138 avatar Nov 14 '19 00:11 don1138

FYI - In a separate issue, I've given the source code fix to get the Loupe working correctly again (Note, I've only tested that in Catalina - it might cause problems in earlier macOS)

DavidPhillipOster avatar Nov 14 '19 04:11 DavidPhillipOster

I applied the change and it's working! Thanks DavidPhillipOster!

IDK if this is a bug or how it always worked, but the window size changes depending on the size of the page being viewed. But hey – as long as I can view books, I'm good.

Here's a link to the binary I compiled: https://drive.google.com/open?id=1yqBQhZwzN-FUYLfisKD27q03CoTqau0D

Enjoy!

Thank you so much good sir!

peirantan avatar Nov 14 '19 21:11 peirantan

FYI - In a separate issue, I've given the source code fix to get the Loupe working correctly again (Note, I've only tested that in Catalina - it might cause problems in earlier macOS)

This binary also adds support for macOS’s native dark mode! 👏

peirantan avatar Nov 24 '19 03:11 peirantan

This binary also adds support for macOS’s native dark mode! 👏

This is most likely due to linking to the 10.14 SDK and no specific changes.

MaddTheSane avatar Nov 24 '19 03:11 MaddTheSane

FYI opening a zip file works fine for me with my original binary in 15.1.

erutan avatar Nov 24 '19 21:11 erutan

I applied the change and it's working! Thanks DavidPhillipOster!

IDK if this is a bug or how it always worked, but the window size changes depending on the size of the page being viewed. But hey – as long as I can view books, I'm good.

Here's a link to the binary I compiled: https://drive.google.com/open?id=1yqBQhZwzN-FUYLfisKD27q03CoTqau0D

Enjoy!

Dude, you are a prince!! Thanks for that!

nthpete avatar Jan 10 '21 21:01 nthpete