spring-boot-starter
spring-boot-starter copied to clipboard
arangodb
Dynamically determining the `ContentType` based on the current Protocol
My Concern:
The documentation https://docs.arangodb.com/stable/develop/integrations/spring-data-arangodb/#configuration emphasizes the need to override the ArangoConfiguration#contentType() method when configuring the driver for a protocol with VPACK content type (e.g., VST, HTTP_VPACK, or HTTP2_VPACK).
My Recommendation:
It is unwarranted for users to explicitly override the content type when opting for protocols like VST, HTTP_VPACK, or HTTP2_VPACK. Instead, this information must be seamlessly retrieved from the existing configuration. Moreover, the obligatory override of the ArangoConfiguration unnecessarily compels users to also override the database and ArangoDB.Builder methods, a requirement that can be deemed superfluous.
Fresh avocado detected! Welcome and thank you for your contribution @bobaikato. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues.
![cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/2404?v=4 "Published by a pub.dev verified publisher"){kind=small}
The CLA link is currently broken, see https://github.com/arangodb/arangodb/pull/20737
The correct link should be: https://arangodb.com/wp-content/uploads/2023/09/Download-Contributor-License-Agreement.pdf
@rashtao I'm supposed to print and sign the document, right? where will it be sent to?
https://arangodb.com/community/#contribute
Just fill in the form, sign and send a scanned copy over to [email protected] or via fax +49-221-2722999-88
@bobaikato
Sorry, this has been automatically closed as I switched the main branch from master to main, and deleted the master branch.
Please reopen against the main branch.
Also please confirm whether you signed the CLA above.
Thank you!
Hey! No problem, I'm happy to open it. Could you possibly send an electronic file I can sign? It's challenging to remember to print and sign.
