python-arango icon indicating copy to clipboard operation
python-arango copied to clipboard

Custom JSON serializer not being used for bulk operations

Open sushi2all opened this issue 2 years ago • 2 comments

Hello, thanks so much for your work. I'm loving the library and relying heavily on it for a new enterprise web app.

I'm setting up import procedures but had troubles because the custom serializer is not being used with the import_bulk and insert_many methods of the collection (and possibly in other bulk operations).

When inserting a single document the custom serializer is working fine.

Can this be implemented?

sushi2all avatar Jan 09 '23 10:01 sushi2all

Hi @sushi2all,

Yes I believe this is possible. I'll keep this open to track the feature request.

joowani avatar Feb 01 '23 08:02 joowani

Hi @sushi2all

Could you please be a bit more explicit? What do you mean by "the custom serializer is not being used"?

It is being used by all methods that send a request, including the ones you mentioned: insert_many and import_bulk. Could you please double-check that? Maybe the problem got fixed in the meantime.

I tested it locally, with the last release (7.9.1). Data is always normalized while processing every request. I hope I'm not being overly confusing here by pointing at the code (that's not the idea), I'm just trying to check whether I got your question right.

Please let me know whether the problem is still there, otherwise I think we can close the issue.

apetenchea avatar May 20 '24 18:05 apetenchea

Closing as completed. Feel free to open another one in case you still experience any issues.

apetenchea avatar May 25 '24 15:05 apetenchea