go-driver icon indicating copy to clipboard operation
go-driver copied to clipboard

Published 20 hours ago • verified publisher icon arangodb

Type dispartity in JournalSize

Open virmundi opened this issue 7 years ago • 1 comments

driver.SetCollectionPropertiesOptions has an int64 while driver.CreateCollectionOptions has a simple int. I have to explicitly cast it. From a modeling perspective one needs to be chosen over the other.

virmundi avatar Dec 22 '17 14:12 virmundi

@virmundi Thanks for the find. Changing this will break the existing API, but only in a small way. We'll see what we can do about it.

ewoutp avatar Jan 23 '18 06:01 ewoutp

We have fixed it in V2 version of drivers: https://github.com/arangodb/go-driver/blob/eda9ddfc1920bef842645703c2559ceeb2da692d/v2/arangodb/collection_opts.go#L119-L119 https://github.com/arangodb/go-driver/blob/eda9ddfc1920bef842645703c2559ceeb2da692d/v2/arangodb/collection_opts.go#L157-L158

In V1 we will leave it as is since that change would be not backward compatible.

jwierzbo avatar Jul 28 '23 13:07 jwierzbo