jenkins_api_client icon indicating copy to clipboard operation
jenkins_api_client copied to clipboard

Release new gem version?

Open timsutton opened this issue 4 years ago • 2 comments

It seems like are significant changes in master since the last release, which was years ago. Would it be possible to cut a new gem version based on the current state of master?

timsutton avatar Dec 03 '20 15:12 timsutton

Please release a gem version compatible with ruby 3.2.1. Thanks!

ninp0 avatar Jan 05 '21 15:01 ninp0

@arangamani 🙇

grosser avatar Apr 18 '22 16:04 grosser

Do we need to add more maintainers? Looks like the gem is not maintained currently?

capripot avatar Feb 08 '23 22:02 capripot

yeah

grosser avatar Feb 08 '23 23:02 grosser

Hi @capripot and @grosser ,

I was using the library myself. But since the maintainer does not seem to be active anymore I have decided to create a new gem based on this one: https://github.com/asghaier/jenkins_api_client2

I will take it easy for now, I just made sure that it builds and runs the unit tests successfully for the latest Ruby releases. Then I will look into open issues and PRs for this project and try to merge them in jenkins_api_client2. I have also updated the CI pipelines to use Github Actions but still need to remove Travis CI configs later on.

I hope the original owner would add other maintainers, but I am currently using a release from 2017 and the maintainer is not responding to anything for over 3 years.

asghaier avatar Mar 13 '23 12:03 asghaier

@asghaier are you willing to be a maintainer of this project?

arangamani avatar Mar 14 '23 00:03 arangamani

I'd also be willing to do some basic maintenance (merge PRs/bump versions etc) if necessary, not deep into jenkins but need the gem for a project for at least another year or so.

grosser avatar Mar 14 '23 00:03 grosser

@grosser Perfect! What email should I use for inviting you to rubygems.org?

arangamani avatar Mar 14 '23 08:03 arangamani

[email protected]

grosser avatar Mar 14 '23 16:03 grosser

If I am able to get it with ruby-3.1.3 because of heroku push for ruby-3.1.3 I will also be using the project for a few years.

Letting you know that I am using the master branch since 2018 and had no issues.

First thing I tried to do is get rspec working

Finished in 10.56 seconds (files took 0.81205 seconds to load)
376 examples, 115 failures, 2 errors occurred outside of examples

@grosser @asghaier want to join forces on this one and bring it up to ruby -> 3.1 and merge some of the prs, instead of maintaining our own forks.

thebravoman avatar Mar 19 '23 11:03 thebravoman

all good now ... but functional tests are broken ...

grosser avatar Mar 20 '23 01:03 grosser

How critical are those functional tests? Can we get away with doing quick manual test for a release?

arangamani avatar Mar 20 '23 01:03 arangamani

ah they were always broken so 🙈

grosser avatar Mar 20 '23 01:03 grosser

2.0.0 🤞 ... I'll yank if it's broken ...

grosser avatar Mar 20 '23 02:03 grosser

@ccouzens also volunteered to help

grosser avatar Mar 20 '23 02:03 grosser

@ccouzens also volunteered to help

Collaborator invite sent.

arangamani avatar Mar 20 '23 02:03 arangamani

@arangamani @grosser you can add me as a co-maintainer if you want. My initial goal for now is to make sure it works with ruby 3.0 and above fore at least next year or two.

asghaier avatar Mar 20 '23 03:03 asghaier

@ccouzens also volunteered to help

Collaborator invite sent.

Thanks both.

Unfortunately I no longer have the time to be a co-maintainer of this project.

It sounds like this project has 2 good new maintainers, so I'm happy the project's future is bright. Good luck 🙂

ccouzens avatar Mar 20 '23 20:03 ccouzens

Thanks for the release, @grosser :tada:

ashkulz avatar Mar 21 '23 02:03 ashkulz