jenkins_api_client icon indicating copy to clipboard operation
jenkins_api_client copied to clipboard

Proper RC's

Open luke-hill opened this issue 7 years ago • 9 comments

Can I make a suggestion that given there has been a bunch of activity on this repo over the last 3 months or so we create and hit some proper RC's.

Given there has been a good 40 commits into master, we need to maybe think about when the next version of this is released how many things could go wrong?

cc/ @katelovescode As you seem to have the auth creds

luke-hill avatar Jan 09 '18 11:01 luke-hill

See #264 for thoughts and recommendations. @arangamani needs to review.

katelovescode avatar Jan 21 '18 21:01 katelovescode

This is in progress now. So will close this in a few weeks if the wheels turn more.

luke-hill avatar Feb 02 '18 15:02 luke-hill

@luke-hill sitting down to review the additional tickets listed in #264 - my preference is that you leave this open until we get the release out; just wanted to give you an update.

katelovescode avatar Feb 13 '18 01:02 katelovescode

Cool thanks for that. Yeh I'll close it once a release candidate of "some" value is cut.

luke-hill avatar Feb 13 '18 08:02 luke-hill

Any updates on this? We're still merging in code and haven't cut anything.

luke-hill avatar May 01 '18 12:05 luke-hill

All the things we've been testing and merging are going into v2.0, as detailed here: https://github.com/arangamani/jenkins_api_client/pull/264/files We're still working on it.

katelovescode avatar May 01 '18 17:05 katelovescode

Oki, is there a reason you're merging like 20+ PR's into one release candidate? Especially if it's a breaking change?

luke-hill avatar May 02 '18 08:05 luke-hill

Given that it's a breaking change, it justifies a major version release. @arangamani and I chatted it out back when you requested this and decided it made sense to pull in all these languishing PRs and make a v2.0. Edit: Github doesn't seem to want to link to the comment thread on the PR on the Changelog, but anyway, we decided to loop them all in and make a v2.0 after listing out all the changes.

katelovescode avatar May 02 '18 14:05 katelovescode

Hey @katelovescode , why was #264 closed? Is there anything one could do to bring this forward?

primeapple avatar Aug 17 '20 11:08 primeapple