clinica
clinica copied to clipboard
Add BIDS reading task to Pydra
Integrated from preliminary work done in pydra-bids.
This implementation passes the tests, but there are issues with type alignments between the nipype tasks and the BIDS reader task. I am investigating.
Looks like I found the issue. Testing on T1 linear works as expected.
I wonder whether we can do better than converting the query results to a tuple or single value and listing the keys to the output spec. Best would be to be able to say I am going to return a dictionary (directly resulting from the query) whose keys are listed in the output spec of the FunctionTask.
I have asked on Mattermost, we'll see. So far, this solution is doing the job.
I think it makes sense to add the functionality to filter on subject/session in this PR.
That's gonna take longer then. Is that ok?
I think it makes sense to add the functionality to filter on subject/session in this PR.
That's gonna take longer then. Is that ok?
I mean it's primary reason brought forward motivating the use of ancpbids so it seems the PR is not complete without this feature
I have iterated quite a bit on this since the initial design and eventually reached a design for tasks defining dynamic specifications that I am happy with. It is easily testable and easier to read than the initial design based on factories.
Since pydra-bids will likely appeal to a wider audience than just Clinica, I'd propose to publish it as its own package and have Clinica depend on it.
I'd propose to publish it as its own package and have Clinica depend on it.
https://pypi.org/project/pydra-bids/