clinica icon indicating copy to clipboard operation
clinica copied to clipboard

Add readthedocs deployment

Open mdiazmel opened this issue 2 years ago • 7 comments

This PR adds support for deploying Clinica's documentation in readthedocs, initially, for testing purposes.

mdiazmel avatar Jul 01 '22 14:07 mdiazmel

An example of the final render can be seen here: https://clinica--691.org.readthedocs.build/en/691/

mdiazmel avatar Jul 01 '22 15:07 mdiazmel

I'd choose this over #699 considering ClinicaDL is already hosted on RTD.

ghisvail avatar Jul 15 '22 16:07 ghisvail

There are currently some problems with the automatic configuration done by RTD on the webhook that comunicates with Github: SS_RTD Same on ClinicaDL. It seems that the github App proposed by RTD doesn't have the correct permissions to send info about the build status. I've been trying to re-configuring from scratch several time without success. If some one want to try it again, please contact me to add him/her to the RDT project maintainers.

mdiazmel avatar Jul 18 '22 09:07 mdiazmel

@mdiazmel, is there any update on this PR? Should we close ?

omar-rifai avatar Sep 27 '22 12:09 omar-rifai

This PR is related to #699 . Clinica's team have to decide if you want to migrate the documentation to RTD or not!

Pros

  • Offload the maintenance tasks of the hosting webserver in an external service.
  • Publishing and deploying is done by external agents.
  • Have the same pipeline than ClinicaDL.

Cons

  • Less control on the customization of the MkDocs template.
  • Need to change references to the doc in all the code (and in Clinica's website).
  • In some sporadic cases, RDT doesn't trigger the documentation building as planned (probably related to a misconfiguration of the webhook, to investigate).
  • ~~RTD doesn't manage poetry~~ (probably solved after recent release of poetry that allows fine control of optional dependencies).
  • Need to communicate to current users in order to update theirs bookmarks.

Anyway, I won't be able to work on these PRs for the moment.

mdiazmel avatar Sep 27 '22 13:09 mdiazmel

@mdiazmel, is there any update on this PR? Should we close ?

And yes, it can be closed.

mdiazmel avatar Sep 27 '22 13:09 mdiazmel

Ok thanks for the recap. I'll add to the agenda for discussion on friday.

omar-rifai avatar Sep 27 '22 13:09 omar-rifai