Aram Greenman

Results 7 comments of Aram Greenman

@ghiculescu added a boolean setting on the adapter. It currently defaults to the new behavior, but lmk if it would be preferable to default to the old behavior and/or if...

> For backward compatibility, the default should be `false`. Then users can set it to `true` to opt in to the behaviour. thanks @ghiculescu, updated the PR

Thanks for the clarification @ghiculescu @matthewd, that all makes sense to me. Since not all databases support a duration-like type, would it make sense to do this deprecation for all...

@matthewd @ghiculescu added the deprecation warning for all adapters. BTW it looks like there was mysql-specific quoting recently added in https://github.com/rails/rails/pull/44408, but the purpose of that PR was to mitigate...

@ghiculescu @matthewd I think this PR is ready, lmk if there's still anything I need to do to move it forward

@gregmolnar rebased, just had a conflict in the CHANGELOG.

@ghiculescu updated the description and rebased.