hass-hue-icons
hass-hue-icons copied to clipboard
Enlarges icons when installed with some other icon packs
Describe the bug When hass-hue is installed with some other icon packs, it enlarges the icons
To Reproduce Steps to reproduce the behavior:
- Have hass-hue-icons installed
- Install another icon pack, (ex. cupertino-icons)
Expected behavior The installed icons should play nice together
Screenshots
Desktop (please complete the following information):
- OS: only happens on iOS and the iOS HA apps
Additional context Related to this issue opened for cupertino icons: https://github.com/menahishayan/HomeAssistant-Cupertino-Icons/issues/4 Related to this reported frontend issue: https://github.com/home-assistant/frontend/issues/10556
Looks like font-awesome had the same issue, but it got fixed in this release https://github.com/thomasloven/hass-fontawesome/releases/tag/2.1.5 and this commit specifically: https://github.com/thomasloven/hass-fontawesome/commit/cb7b171e9cc0f54729d4dd69446a434267db0169
Maybe that solution can be applied to this integration?
Interesting. Thanks for this. The fixed integration has access to code the plugins do not, but I'll look to see if there's a comparable fix. Will come back with findings.
Seems to be an issue introduced in HA 2021.X, and affects the way the frontend handles custom icon sets. Thomasloven fixed it by adding a specfic style to their integration, as does this fix for cupertino. Hass-hue-icons isn't served as an integration, but a plugin, which prevents us from applying a similar fix. I'll keep an eye on it, but I don't think there's any way for me to force HA to change its behaviour from here.
Thanks for linking the cupertino issue, as that's helped me find the common thread with the fontawesome fix.
Thanks for the explainer @arallsopp. Sounds like it’s up to HA or integration owners to solve it, so I’ll keep at the issues there. You can close this one as far as I’m concerned, or keep it open/stickied so others see it when they notice it as wel. Up to you!
I've created a new version of the repo which installs as an integration here. This should include the style fix, so might be worth evaluating.
Making an integration means starting over with the stars and submission to hacs, creating a new build process, etc, so I might not be maintaining it as regularly as this repo. You have to uninstall this one before you can try the implementation, so if you can live with the current feature set, don't worry about trying it out :)