kanban.nvim icon indicating copy to clipboard operation
kanban.nvim copied to clipboard

Working with the community version of obsidian.nvim

Open neo451 opened this issue 8 months ago • 9 comments

Found this issue in the old repo: https://github.com/epwalsh/obsidian.nvim/issues/62

We are working on a fork at obsidian-nvim/obsidian.nvim

Not sure what your intention now is, but I think we can work more together.

Like for now this plugin calls nvim-cmp at initialization, but many users using the new repo would be using blink.cmp. I think we can tackle this first.

Also some further proposals in the long run:

  1. If you want we can move this repo to our org, or just be moved inside as a module https://github.com/obsidian-nvim/obsidian.nvim/issues/81
  2. I am working on providing a builtin lsp server, so that we delete all completion plugins integrations, something your plugin can also benefit in the long run.

neo451 avatar Apr 29 '25 09:04 neo451

@neo451

Thank you so much for the great work and initiative!

I’ll start working on the support for blink.cmp—it definitely makes sense given the direction of the new repo. Apologies for the long silence; I haven’t been able to maintain this for a while, so I’ll take this opportunity to review and get things moving again.

Also, I’d like to consider moving this into the main repo as a module. If you have specific steps or suggestions for how best to proceed with that, I’d really appreciate your guidance.

Thanks again!

arakkkkk avatar May 05 '25 01:05 arakkkkk

Some things I think we can do first:

  1. make this plugin aware of obsidian workspaces, since it just makes sense to create kanban in vaults if user uses obsidian.nvim
  2. you can go ahead and see what utils in the main repo you can use to simply your code, or contribute what things you wrote like some general ui helpers that you think the main repo can use.
  3. I can also just add you as a member of our org, and you can move the repo there first if you want, so that more folks could see it and maybe participate.
  4. We maybe figure out the rest later in the future.

It could still be a lot that I am asking, we can slowly move about this.

neo451 avatar May 05 '25 09:05 neo451

the later part of how integration can be achieved is related: https://github.com/orgs/obsidian-nvim/discussions/140

neo451 avatar May 09 '25 11:05 neo451

Thank you! If it's okay with you, I'd like to proceed in the following order:

  1. Add support for blink.cmp
  2. Add support for reading vaults
  3. Refactor the code (basic cleanup to make future development easier within the org)
  4. Create an MR to move the plugin into obsidian.nvim
  5. Simplify the code using shared utils and contribute any reusable utils I’ve written

This might take me a little bit of time. If quicker action is needed, I’m also open to prioritizing the move to obsidian.nvim first, and then working on enhancements afterward. Let me know what you think.

Thanks again!

arakkkkk avatar May 13 '25 13:05 arakkkkk

take your time and ask me for anything

neo451 avatar May 13 '25 15:05 neo451

@arakkkkk See the wiki here when you want to build the integration: https://github.com/obsidian-nvim/obsidian.nvim/wiki/Extensions

neo451 avatar Jun 21 '25 13:06 neo451

@neo451 Sorry for the delay I've created a plugin called obsidian-kanban, and I'd like to include it under the obsidian-nvim organization. Would it be possible to add me as a member so I can transfer the repository? I'd like to add support for completion later, since it might be a bit complex. Thanks!

arakkkkk avatar Jul 05 '25 15:07 arakkkkk

@arakkkkk thank you for your work, I'll gladly invite you to the org.

A few thoughts and questions.

  1. I did not expect you to create a new one, since you have existing users, and they might get lost.
  2. the integration guide might not be super clear, you could have just made
├── LICENSE
├── lua
│   └── obsidian
│       └── commands
│           └── kanban.lua # return the actual command itself, can just contain the one function required from kanban
│   └── kanban # your original logic
├── plugin
│   └── kanban.lua # register your command here
└── README.md
  1. so if you made a new repo just for this integration's sake, there's no need, or else I would like to know the reason behind it, and how is its relation to the current vault, we can also not transfer if you like, no pressure.
  2. there's a new WIP kanban plugin, https://github.com/hasansujon786/super-kanban.nvim, which has more scope, and also would like to provide integration. It is nice for me to see "competing" in the ecosystem, and yours can be one that is more minimal and sticks to markdown system, but I think you can also learn a lot form that one.
  3. yes completion takes more effort, just go at your pace. obsidian.nvim's lsp completion is going to take a super long time to land and be able to be extensible enough to allow plugins like yours to use it. but once it lands, it would be super useful, for now you can also just reference the super-kanban.nvim and obsidian.nvim's completion implementation.

neo451 avatar Jul 06 '25 04:07 neo451

@neo451

Thank you for inviting me to the organization, and also for your valuable suggestions.

1/2/3 I see— I had a misunderstanding. I agree that it's better not to make changes to this repository, and I'm happy to go in that direction. The approach you suggested seemed like a good solution, so I’ve adjusted the code accordingly. I also updated the README.md with a brief explanation of the changes. Please let me know if you'd like me to expand on anything or make further adjustments.

4/5 Supre-kanban looks like a fantastic plugin—it's clearly much more feature-rich than mine. I'd love to consider either using it as a reference or possibly collaborating in some way. Thank you for sharing it!

arakkkkk avatar Jul 06 '25 13:07 arakkkkk