Arunprasad Rajkumar

Results 73 comments of Arunprasad Rajkumar

@dimitri Yes, I will polish #725 to address this.

@dimitri I'm wondering this would also require to change the way we read files in other places right? For example, the below code reads the entire file content to memory...

@dimitri , Absolutely! I already have a WIP patch, will create a PR soon. Thanks for reviewing this issue.

@theothornhill We have implemented on our fork which is yet to be upstreamed. The implementation also has to adopt the new sqlite catalog changes, hopefully will do some overhaul next...

Tests are failing with the following message., > The action 'Run a test' has timed out after 5 minutes.

@dimitri > I'm now wondering about using --exclude-table-data. Sorry didn't think about it before. Yeah, I thought of it, but I felt the approach used in this PR is quite...

> We need to see if these entries contain the OID of the MATVIEW only, or also the nspname and relname, and we need to match that name to the...

> ``` > 6712; 0 93394 MATERIALIZED VIEW DATA public metrics_count tsdbadmin > ``` @dimitri IIUC, catalog id is 0 and oid is 93394. The below is a result of...

@dimitri Modified the implementation to use filter catalog to filter matview and refresh.

> LGTM. Added a small comment to refactor if into switch, other than that it feels ready to merge. Will mark as such, please send a last round of update...