Arunprasad Rajkumar

Results 92 comments of Arunprasad Rajkumar

With little bit of tinkering, I could run the upstream [jaeger integration tests](https://github.com/jaegertracing/jaeger/blob/71f2bb99f65b502ec935b05adbd6f8025c8f3bdf/plugin/storage/integration/integration_test.go#L382-L388). ``` t.Run("GetServices", s.testGetServices) t.Run("GetOperations", s.testGetOperations) t.Run("GetTrace", s.testGetTrace) t.Run("GetLargeSpans", s.testGetLargeSpan) t.Run("FindTraces", s.testFindTraces) t.Run("GetDependencies", s.testGetDependencies) ``` in the above...

> t.Run("GetLargeSpans", s.testGetLargeSpan) The above test ingests 10K spans under a single trace id and get them in a single GetTraces operation.

Here is a test result without `GetLargeSpans` [tests.log](https://github.com/timescale/promscale/files/9496768/tests.log)

Test execution summary: ``` --- FAIL: TestExternalGRPCStorage (212.15s) --- PASS: TestExternalGRPCStorage/GetServices (0.21s) --- PASS: TestExternalGRPCStorage/GetOperations (0.00s) --- PASS: TestExternalGRPCStorage/GetTrace (0.01s) --- PASS: TestExternalGRPCStorage/GetTrace/NotFound_error (0.00s) --- FAIL: TestExternalGRPCStorage/FindTraces (211.93s) --- FAIL:...

> FAIL: TestExternalGRPCStorage/FindTraces/Tags_in_one_spot_-_Tags (10.72s) The current find trace query does a `INNER JOIN on span & event` which would cause failure to find a trace which doesn't have any event....

When I use `LEFT JOIN` for event and span table merge, I see the following tests are passing additionally but [above listed](https://github.com/timescale/promscale/issues/1621#issuecomment-1239054206) problem remains for other tests, ``` TestExternalGRPCStorage/FindTraces/Tags_in_different_spots TestExternalGRPCStorage/FindTraces/Operation_name_+_Duration_range...

Few more are passing after adding a second delay in grpc_test Refresh function. Looks like a bug in somewhere in the grpc plugin implementation(Note `tracing.asyc-acks` are not enabled). --- PASS:...

> --- FAIL: TestExternalGRPCStorage/FindTraces/default (10.40s) This one fails when operationName field of Span is [empty](https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/integration/fixtures/traces/default.json#L6). ### EDIT: Following error is thrown when OperationName is empty, >ERROR: new row for relation...

>--- FAIL: TestExternalGRPCStorage/FindTraces/Multi-spot_Tags_+_Operation_name (10.81s) >--- FAIL: TestExternalGRPCStorage/FindTraces/Multi-spot_Tags_+_Operation_name_+_max_Duration (10.76s) >--- FAIL: TestExternalGRPCStorage/FindTraces/Multi-spot_Tags_+_Operation_name_+_Duration_range (10.70s) >--- FAIL: TestExternalGRPCStorage/FindTraces/Multi-spot_Tags_+_Duration_range (10.70s) >--- FAIL: TestExternalGRPCStorage/FindTraces/Multi-spot_Tags_+_max_Duration (10.56s) [trace](https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/integration/fixtures/traces/multispottag_dur_trace.json) [query](https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/integration/fixtures/queries.json#L290-L308) This has a tag query across span, resource...

> GetLargeSpans fixed by [jaegertracing/jaeger#3912](https://github.com/jaegertracing/jaeger/issues/3912) `GetLargeSpans` test still fails when it is run with all other tests specifically `GetTrace`. Here is a test summary, ``` /plugin/storage/integration/integration_test.go:133 Error: Not equal: expected:...