ui icon indicating copy to clipboard operation
ui copied to clipboard

Bottom of the page hidden on iOS

Open pacwoodson opened this issue 6 years ago • 14 comments

There's a recurring issue on iOS browser, where the viewport size is fixed, whatever if the URL or action bar is displayed or not. This result having 100vh usually larger that the actual screen, and not being able to scroll to the end of the page correctly.

Here is a video showing the bug: https://streamable.com/2yguzw

Found this https://css-tricks.com/the-trick-to-viewport-units-on-mobile/ showing a work around, and implemented it in https://github.com/pakokrew/mooni/blob/develop/src/components/ScrollRoot.jsx, which looks like it solves pretty well the issue

pacwoodson avatar Apr 06 '20 13:04 pacwoodson

Can I work on this issue ?

ghost avatar May 31 '20 19:05 ghost

@yannis182del Yes! Thank you :pray:

bpierre avatar May 31 '20 19:05 bpierre

Here's the updated URL of implementation @yannis182del ;)

https://github.com/pakokrew/mooni/blob/master/app/src/components/ScrollRoot.jsx

pacwoodson avatar Jun 01 '20 11:06 pacwoodson

@pakokrew @bpierre Isn't this issue supposed to be on the aragon repo and not aragon-ui ? Not really sure, i'm new to the project haha

https://github.com/aragon/aragon

ghost avatar Jun 02 '20 18:06 ghost

@yannis182del the problem is coming from the ScrollView component in this aragon-ui repo

https://github.com/aragon/aragon-ui/blob/master/src/components/ScrollView/ScrollView.js

pacwoodson avatar Jun 03 '20 09:06 pacwoodson

Thanks @pakokrew! I start to work on this ☺️

ghost avatar Jun 03 '20 18:06 ghost

Hi, @pakokrew @etherean06 is this issue still open?

eliobricenov avatar Feb 11 '21 01:02 eliobricenov

Hi, @pakokrew @etherean06 is this issue still open?

Hi, just tried again on Aragon client, and the bug is still present on Safari iOS.

Here's an updated link to my workaround: https://github.com/pakokrew/mooni/blob/master/app/src/components/Utils/ScrollRoot.jsx

Do you want me to reupload the video showing the bug ?

pacwoodson avatar Feb 11 '21 07:02 pacwoodson

hey @pakokrew, yes, please.

eliobricenov avatar Feb 17 '21 03:02 eliobricenov

@eliobricenov there you are. Only happens on Safari iOS, not firefox.

https://user-images.githubusercontent.com/1371207/108166434-9dbf3700-710d-11eb-8f68-519642b8a31d.mp4

https://user-images.githubusercontent.com/1371207/108166455-a3b51800-710d-11eb-9eb5-231e6d4b94e7.mp4

pacwoodson avatar Feb 17 '21 06:02 pacwoodson

@pakokrew Thank you, that's helpful.

eliobricenov avatar Feb 17 '21 13:02 eliobricenov

I will hold working on this since I currently don't have a safari environment I can test on.

eliobricenov avatar Feb 17 '21 20:02 eliobricenov

Hey all, just started building a project on Aragon UI and was wondering if there was any updates on this, as it's still an issue...

giaset avatar Jun 18 '21 08:06 giaset

@giaset are you facing the same issue? If so, feel free to create a PR with the fix so the team can review it

githubdoramon avatar Jun 26 '21 08:06 githubdoramon