govern Create: Fix proxies consuming all gas on failure

Create: Fix proxies consuming all gas on failure

Open izqui opened this issue 4 years ago • 4 comments

Probably executing invalid instead of revert on failure. Will require editing the bytecode for the proxies

Dec 07 '20 15:12 izqui

Related to #239

Dec 07 '20 16:12 izqui

From EIP1167, the bytecode contained in the proxies don't include any invalid opcodes so I don't think that's the case.

However, the proxies previous to #252 were computing the proxy creation bytecode incorrectly, potentially leading to this behaviour.

Dec 08 '20 14:12 sohkai

Makes sense, will test later

Dec 08 '20 15:12 izqui

I couldn't reproduce the INVALID opcode execution. Tried the proxy bytecode creation before #252 and after #252. Still, nothing.

Would be good if you could write the steps how to reproduce it.

Feb 08 '21 20:02 novaknole