court-dashboard icon indicating copy to clipboard operation
court-dashboard copied to clipboard

Published 20 hours ago • verified publisher icon aragon

Remove hardcoded gas limits

Open sohkai opened this issue 5 years ago • 3 comments

Web3 providers should be able to handle gas estimations on their own. Were we running into any problems with not setting a hardcoded amount?

sohkai avatar Feb 10 '20 18:02 sohkai

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/aragon/court-dashboard/qj8je5iyk ✅ Preview: https://court-dashboard-git-remove-hardcoded-gaslimits.aragon.now.sh

vercel[bot] avatar Feb 10 '20 18:02 vercel[bot]

Yes, if we didn't set a gasLimit, the provider never prompts you to sign and we would get

data:
message: "execution error: revert"
code: -32000

in the console without specific reason.

fabriziovigevani avatar Feb 10 '20 18:02 fabriziovigevani

This is definitely worrying; will look into it. Maybe it's something ethers related but I can't imagine it.

For example, we don't use hardcoded gas limits in the client or CLI except in exceptional cases.

sohkai avatar Feb 10 '20 18:02 sohkai