client icon indicating copy to clipboard operation
client copied to clipboard

Finance: add tracked token (without manual deposit)

Open lkngtn opened this issue 6 years ago • 7 comments

Is your feature request related to a problem? Please describe. If you send a new asset to the vault it will not appear until it has been deposited in the finance app.

Describe the solution you'd like The finance app should allow you to "watch" a token address without depositing it.

Describe alternatives you've considered It would be nice if the finance app automatically detected new tokens when they are sent to the vault, but this seems technically much more difficult and would also potentially clutter the UI with unwanted airdropped tokens.

Additional context Currently users are being asked to only use the finance apps deposit function instead of directly transferring assets to the vault. There are instances where this is really impractical.

lkngtn avatar Feb 19 '19 22:02 lkngtn

Will require https://github.com/aragon/aragon.js/issues/119.

sohkai avatar Feb 20 '19 00:02 sohkai

This would be useful when using the Vault address with Gitcoin Grants

pcowgill avatar Apr 22 '19 19:04 pcowgill

This would be useful when using the Vault address with Gitcoin Grants

(Now the Agent address rather than the Vault address)

pcowgill avatar Jan 24 '20 21:01 pcowgill

Worth noting that this issue also affects usage of the Dandelion template. When a user submits a request using the Token Request app, once the request is approved, the token the user put up in exchange for voting tokens is deposited to the Agent address. However, this deposited token does not automatically show up in either the Agent or Finance app balance section or the transfer history sections of either app. Users must make a small deposit using the Finance app to get all Token Request deposits to show up in the Finance app balance.

Curiously, once a small deposit is made to the Finance app, while this deposit shows up in the Finance app, the original un-accounted deposit shows up in the Agent app but not the later deposit made using the Finance app :thinking: Maybe this warrants opening a new issue - let me know!

Screenshot_2020-07-27 Aragon

Screenshot_2020-07-27 Aragon(1)

john-light avatar Jul 28 '20 00:07 john-light

For additional context: https://www.youtube.com/watch?v=zQrrITthLCA

nya-elimu avatar Jul 28 '20 09:07 nya-elimu

Curiously, once a small deposit is made to the Finance app, while this deposit shows up in the Finance app, the original un-accounted deposit shows up in the Agent app but not the later deposit made using the Finance app 🤔 Maybe this warrants opening a new issue - let me know!

Not sure I understand. From the screenshot, it looks like the later deposit made with the Finance app is displayed correctly in the Agent?

sohkai avatar Jul 31 '20 09:07 sohkai

@sohkai notice the sender in the Finance app is "Satoshi" whereas the sender in the Agent is "0xDB75...". These are different transactions. So the Finance app shows one, and the Agent app shows the other, but neither shows both.

john-light avatar Jul 31 '20 17:07 john-light