aragonOS icon indicating copy to clipboard operation
aragonOS copied to clipboard

Published 20 hours ago • verified publisher icon aragon

ACL: optimize checkOracle()

Open sohkai opened this issue 5 years ago • 1 comments

Updates the ACL's staticcall to use a more-optimized one similar to SafeERC20's invokeAndCheckSuccess().

Bytecode comparison:

                        CODE DEPOSIT COST    DEPLOYED BYTES     INITIALIZATION BYTES
ACL.json                5600 less gas        -28                0
TestACLInterpreter.json 67400 more gas       +337               0

sohkai avatar Mar 26 '19 00:03 sohkai

Coverage Status

Coverage decreased (-0.009%) to 99.531% when pulling 2047972de96f288c2ca48bfc7811cef50ebe8938 on acl-optimize-check-oracle into dca0b4b7f8cdbdaed44e9ea397f7e921cb2e8cec on dev.

coveralls avatar Mar 29 '19 05:03 coveralls