aragon.js icon indicating copy to clipboard operation
aragon.js copied to clipboard

Wrapper: AragonApps w/o permissions are not detected

Open ewingrj opened this issue 7 years ago • 3 comments

The wrapper is using the permissions observable to create the apps observable. If I add a new app w/o setting any permissions, it will not be added to the apps stream.

ewingrj avatar Oct 26 '18 14:10 ewingrj

@perissology An app is technically not installed until there are references to it in the ACL, as a app with no permissions set is effectively a useless app (https://hack.aragon.org/docs/cli-usage.html#dao-install) (assuming roles are being used).

sohkai avatar Oct 26 '18 17:10 sohkai

Is the assumption when installing a new app to an existing dao that a kit will be used & the permissions setup via the kit?

With the permissions app now available, maybe it makes sense to show un-permissioned apps there?

ewingrj avatar Oct 26 '18 18:10 ewingrj

@perissology Hmm... maybe in the App Center, and it could lead you to initialize it and assign permissions. Technically we do have enough information from the SetApp and NewAppProxy events to know if you have an orphaned app without permissions.

The general assumption is that you'll be using some sort of kit / bundler contract that will create, initialize, and assign the initial permissions when installing most apps though.

sohkai avatar Nov 16 '18 13:11 sohkai