aragon.js icon indicating copy to clipboard operation
aragon.js copied to clipboard

Return more details when a transaction path for an intent could not be found

Open sohkai opened this issue 7 years ago • 3 comments

Right now, we simply return an empty array when no transaction path was found.

Returning more data, like the intended to address and parameters would help UIs display more information, like which app or action they couldn't access.

sohkai avatar Aug 29 '18 14:08 sohkai

Related to #219

0xGabi avatar Nov 30 '18 20:11 0xGabi

In the CLI we show: Cannot find transaction path for executing action

But we could show: ${account} is not permitted to perform the action ${action} on the app ${app}.

And then perhaps: Only the following entities can perform ${action}: ${app1}, ${account2}, etc. or Nobody can perform the action ${action}. You must first initialize the permission.

I can tackle this, any tips/ideas?

Should it throw an error with these messages?

kernelwhisperer avatar Jul 16 '19 09:07 kernelwhisperer

Hmm, the problem with just throwing an error is that most clients of the wrapper react on one of the observables firing.

Perhaps we could add more information to the this.transactions observable on each emission, like intended target and reason no path was found.

sohkai avatar Jul 16 '19 14:07 sohkai