aragon-monthly icon indicating copy to clipboard operation
aragon-monthly copied to clipboard

Meta: Can we automate checking for duplicate stories in past issues?

Open john-light opened this issue 6 years ago • 12 comments

It's possible that someone might try to share something that has been featured in a previous issue. While it is not the end of the world if a duplicate story is added, it would be nice to reduce such occurrences. The Editors might miss duplicates, since after so many issues it might be easy to forget or not know what has been covered before.

We should make a bot that can scan new Issues and Pull Requests and detect when a link has been submitted to previous issues of the newspaper.

If there is more interest in creating a bot for this purpose then we can create a bounty that pays whoever makes the bot that does this. Let me know what you think!

john-light avatar Mar 20 '18 20:03 john-light

Hi @john-light if you are still interested I'd love to help with this issue.

leolower avatar Jun 15 '18 17:06 leolower

@leolower yes please! We're starting to get a lot of submissions and I've noticed a duplicate at least once, but it doesn't mean we'll catch it every time. What do you have in mind for a solution?

john-light avatar Jun 18 '18 17:06 john-light

Cool! I was thinking on a probot app hosted on Now or Heroku. It would listen for new issues / PRs, extract the links from the text and compare them against other issues using Github's API or a separate DB. If a duplicate is found it could post a comment or add a label to the issue. It can probably be adapted to the specific workflow you already have. What do you think?

leolower avatar Jun 18 '18 18:06 leolower

That sounds great. Would be good to have it give a link to the issue with the duplicate link in the comment so the submitter can see if the article was previously accepted or not.

john-light avatar Jun 18 '18 18:06 john-light

Current balance: 0.0 ETH Tokens: ANT: 20.00 Contract address: 0x00193ec6824f316c1497470aad12c308a5aee9ec QR Code Network: Mainnet To claim this bounty sign up at https://openbounty.status.im and make sure to update your Ethereum address in My Payment Details so that the bounty is correctly allocated. To fund it, send ETH or ERC20/ERC223 tokens to the contract address.

status-open-bounty avatar Jun 18 '18 18:06 status-open-bounty

@leolower I just added a bounty to this PR. You'll need to create a Status Open Bounty account and submit a PR to this repo that closes this issue to claim the bounty. If a PR is unnecessary to claim the bounty then we should discuss with @Smokyish the best way to do this -- either manually send you the bounty out of band or submit a PR adding some documentation about the bot would probably suffice.

john-light avatar Jun 18 '18 18:06 john-light

Yes, I would recommend keeping the bot on a separate repository and adding instructions for submitters on this repo's readme of issue templates.

leolower avatar Jun 18 '18 19:06 leolower

Hello, we've made some progress on the bot.

I have configured it on a dummy repository as an example: https://github.com/leolower/drone-test/issues

On that repo you can see that issues have different links and whenever a new issue is posted the bot checks all new links and if a duplicate is found, it posts a comment with links to the original issue.

Let me know what you think!

leolower avatar Jul 02 '18 14:07 leolower

Very cool, thanks @leolower! I will take a look. Also pinging @Smokyish to take a look.

john-light avatar Jul 02 '18 15:07 john-light

By the way, you can submit issues with links on that repo to test it. If you like it I can provide instructions on how to set it up on your repo and if you prefer, run it on a server of your own.

The code is here: https://github.com/protofire/aragon-links-bot

leolower avatar Jul 02 '18 15:07 leolower

Hi! Any news on this? Let me know if you have suggestions or changes you want to make on the app.

leolower avatar Jul 10 '18 13:07 leolower

Hi @leolower, sorry for the late response, summer got in the way.

Haven't had a chance to test this in action, but your tests in the repo look promising!

Smokyish avatar Jul 30 '18 13:07 Smokyish