Ilya Konovalov

So that the snippet would become like this? ```python for item in some_iterable: try: for attempt in Retrying( stop=stop_after_attempt(5), before_sleep=before_sleep_log(logger, logging.DEBUG, label=f"doing stuff with {item}"), wait=wait_fixed(10)): with attempt: data =...

I've moved the "get label" code to the RetryCallState class and modified all the log functions to use it.

Looks like the fix is to use new functions like `org-element-begin` instead of `org-element-property :begin`. However to keep backward compatibility with org 9.6 the code should check for that new...

The fix is to go through all files and replace calls to `org-element-property` that access `:begin`, `:end`, `:content-begin` and `:content-end`. I've created a pull request with the fix applied.

`:begin` and `:end` are used in multiple places in org-roam code -- my fix replaces them all with correct calls. As soon as you apply my fix, the issue should...

Yes, this is exactly how I understood it. The question is -- should it be fixed? Is it worth implementing a different valuation request which will use first price instead,...

When calculating roi for certain period we want the price at the end of period. Current implementation is to use the price for the first day _after_ that period, which...

The original issue was that when calculating `roi` for day X it uses the price for day X+1 and if there are multiple prices for day X+1 that affects the...

It's not about "why data for May is wrong". It's about looking at a correct April file with all the April data in it but getting incorrect result because of...

I think adding it to strict check would be enough.