Antonin RAFFIN

Results 880 comments of Antonin RAFFIN

> onsistent pattern across all algorithms to access values functions just like predict for the action ? not really... Only between algorithms of the same family... > For some application,...

> re the Q/V networks decent estimations of the true functions or not ? that's hard to give only one answer, we surely hope they are, but that doesn't mean...

@Gregwar I could successfully test it =) I had to do some tweaks to use it with conda env: ```shell export CMAKE_PREFIX_PATH="${HOME}/.local/lib/libtorch:/home/user/miniconda3" ``` where the conda prefix can be retrieved...

> It will be hard to be sure to cover all the cases else, Let's do a first working version that covers only some algorithms (let's say PPO, DQN and...

@Gregwar could you give me access to your repo so I can push changes? (mainly merging master with this branch)

Hello, good point, we would welcome a PR that solves this issue ;) ps: as we synchronise the stats at every evaluation, this should not change previous results much.

when using enjoy, this is already the case: https://github.com/DLR-RM/rl-baselines3-zoo/blob/89d4e0c757f2309d506f32b6bf97eaaddf091209/utils/utils.py#L246

> including packages that don't support Windows. which packages are not supported by windows? EDIT: I assume pytype, box2d and pybullet are the one

Could you submit a PR that adds a note for installation for windows users (I think you can get pybullet with conda forge)

> I will check that everything installs on Window if I remove extra and submit a PR you probably need to remove more. I managed to work with SB3 on...