qlbridge
qlbridge copied to clipboard
Proto3 & expr.Expr json
The goal of this pr is two-fold
- Upgrade to protobuf 3
- implement Round Tripping to ensure expressions can be represented as both JSON OR protobuf and all unit tests pass after serialization. refs #146
TODO
- [ ] verify downstream usage won't break
Codecov Report
Merging #205 into master will decrease coverage by
0.68%. The diff coverage is65.81%.
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 68.12% 67.43% -0.69%
==========================================
Files 87 87
Lines 16192 16741 +549
==========================================
+ Hits 11030 11289 +259
- Misses 4310 4535 +225
- Partials 852 917 +65
| Impacted Files | Coverage Δ | |
|---|---|---|
| plan/plan.go | 44.4% <25%> (-1.39%) |
:arrow_down: |
| expr/node.go | 52.63% <66.32%> (-1.37%) |
:arrow_down: |
| rel/sql.go | 45.81% <73.33%> (+0.99%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 01687b6...f0d1ce7. Read the comment docs.