disableEslint doesn't seem to have effect on react-scripts@4

Open layerssss opened this issue 5 years ago • 1 comments

Hi team,

After upgrading to react-scripts@4 (from 3.x), disableEslint seems to no longer having any effects. Both the react-app-rewired start process and browser console start to throw eslint warnings and errors. I'm not sure whether this should be a customize-cra or react-app-rewired issue though, so trying open it here first.

I have made a minimum example to reproduce this: https://github.com/layerssss/cra4-customize-issue

Expect result: the yarn start process and browser console should NOT have the no-unused-vars warning Actual: the warning is present.

Dec 16 '20 21:12 layerssss

This is fixed in #278.

Dec 19 '20 10:12 Menci