customize-cra icon indicating copy to clipboard operation
customize-cra copied to clipboard

Published 20 hours ago • verified publisher icon arackaf

Update less-loader options

Open dbwcooper opened this issue 4 years ago • 12 comments

Use lessOptions instead of the options at [email protected] https://github.com/arackaf/customize-cra/issues/241 https://github.com/arackaf/customize-cra/issues/231

dbwcooper avatar May 05 '20 11:05 dbwcooper

also #242

SamKirkland avatar May 05 '20 15:05 SamKirkland

@arackaf could you take a look at this?

AO19 avatar May 26 '20 11:05 AO19

This PR not fix #242.

https://github.com/bowen0/customize-cra/blob/2e924d2dfff5fb4d91e53988a322fa881e5df3ce/src/customizers/webpack.js#L131-L132

https://github.com/bowen0/customize-cra/blob/2e924d2dfff5fb4d91e53988a322fa881e5df3ce/src/customizers/webpack.js#L193-L196

https://github.com/bowen0/customize-cra/blob/2e924d2dfff5fb4d91e53988a322fa881e5df3ce/src/customizers/webpack.js#L145-L148

this code still cause the problem.

xyy94813 avatar May 26 '20 14:05 xyy94813

Hey all - I'm not really involved with this project anymore. Is anyone here interested in becoming a maintainer?

arackaf avatar May 26 '20 16:05 arackaf

Hey folks,

I've received maintainer access from Adam since he's unable to contribute/involved with the project anymore. First priority is to fix the css-loader/less-loader issues currently prevalent in the master branch due to the changed options format.

There was a working change implemented in #185 on the next branch, which can be further enhanced by @edwardwang0302's changes in #214. These were held off from master due to them being breaking changes, but due to the backlog of issues, I'm going to run through the existing PRS tomorrow, test each of them, and then make a fix-merge into master so that the css-loader/less-loader issues can be fixed immediately.

Does that sound good? Open to thoughts/implementation details.

Anish-Agnihotri avatar May 27 '20 02:05 Anish-Agnihotri

@xyy94813 PR #185 with the new implementation of getStyleLoaders should fix #242. I'll check tomorrow and merge if so.

Anish-Agnihotri avatar May 27 '20 02:05 Anish-Agnihotri

@Anish-Agnihotri

Yeah!!!!! This PR #185 is what I am going to do. I found it has been merge into next branch. I'm very excited that someone has already done this.

xyy94813 avatar May 27 '20 04:05 xyy94813

any timeframe for a release?

leojh avatar May 27 '20 17:05 leojh

@leojh Testing and working on it right now. Pushing for a release hopefully before EOD tomorrow (if not, latest-Friday).

The changes are already implemented in the next branch. You can test by installing customize-cra@next to see if that resolves your issues. But, since it's a breaking-change I want to make sure everything is in order before I merge into master.

Anish-Agnihotri avatar May 27 '20 18:05 Anish-Agnihotri

thank you will do! thank you for keeping this package going.

leojh avatar May 27 '20 18:05 leojh

works!

leojh avatar May 27 '20 18:05 leojh

Hey folks,

The changes in the @next branch have been pushed upstream and merged into master. Please follow the migration guide in #253, which will have you nest your configuration in the lessOptions object.

Hopefully this resolves a majority of the issues in the thread. Please do let me know if you still run into issues; I'll keep this PR thread open for a few days.

Anish-Agnihotri avatar May 28 '20 21:05 Anish-Agnihotri