arackaf
Update less-loader options
Use lessOptions instead of the options at [email protected] https://github.com/arackaf/customize-cra/issues/241 https://github.com/arackaf/customize-cra/issues/231
This PR not fix #242.
https://github.com/bowen0/customize-cra/blob/2e924d2dfff5fb4d91e53988a322fa881e5df3ce/src/customizers/webpack.js#L131-L132
https://github.com/bowen0/customize-cra/blob/2e924d2dfff5fb4d91e53988a322fa881e5df3ce/src/customizers/webpack.js#L193-L196
https://github.com/bowen0/customize-cra/blob/2e924d2dfff5fb4d91e53988a322fa881e5df3ce/src/customizers/webpack.js#L145-L148
this code still cause the problem.
Hey all - I'm not really involved with this project anymore. Is anyone here interested in becoming a maintainer?
Hey folks,
I've received maintainer access from Adam since he's unable to contribute/involved with the project anymore. First priority is to fix the css-loader/less-loader issues currently prevalent in the master branch due to the changed options format.
There was a working change implemented in #185 on the next branch, which can be further enhanced by @edwardwang0302's changes in #214. These were held off from master due to them being breaking changes, but due to the backlog of issues, I'm going to run through the existing PRS tomorrow, test each of them, and then make a fix-merge into master so that the css-loader/less-loader issues can be fixed immediately.
Does that sound good? Open to thoughts/implementation details.
@xyy94813 PR #185 with the new implementation of getStyleLoaders should fix #242. I'll check tomorrow and merge if so.
@Anish-Agnihotri
Yeah!!!!! This PR #185 is what I am going to do.
I found it has been merge into next branch.
I'm very excited that someone has already done this.
@leojh Testing and working on it right now. Pushing for a release hopefully before EOD tomorrow (if not, latest-Friday).
The changes are already implemented in the next branch. You can test by installing customize-cra@next to see if that resolves your issues. But, since it's a breaking-change I want to make sure everything is in order before I merge into master.
Hey folks,
The changes in the @next branch have been pushed upstream and merged into master. Please follow the migration guide in #253, which will have you nest your configuration in the lessOptions object.
Hopefully this resolves a majority of the issues in the thread. Please do let me know if you still run into issues; I'll keep this PR thread open for a few days.