Chris Webb

Results 43 comments of Chris Webb

> > Is there a standard mechanism to register a module other than loading it from a .py file? > > Yes! You can insert a module directly into [`sys.modules`](https://docs.python.org/3/library/sys.html#sys.modules)....

> > I propose to write a full set of tests to cover as much as I can of that decorator, but will submit in a separate PR. > >...

Rebased onto an up-to-date master.

I think the relevant register is MMIO mapped at 0xfed803c0, but it's not obvious to me where this would be trapped in CH. I'll have a dig but I can't...

This is great! The lack of discard support has been one of the major drawbacks of both firecracker and cloud-hypervisor compared to qemu. I guess a future enhancement might be...

I decided to do a little casual testing with this PR, on my linux-musl x86-64 dev host. I created a small, fully allocated disk image on the host's tmpfs /tmp...

Until @lisongqian is about, maybe I can help out with some notes on the importance of discard support, as you asked for @likebreath? With guest drives provisioned directly onto SSDs...

> @arachsys Thank you for your testing. I merge the iovecs to a entry of queue. Bug has been fixed. Thanks, it has indeed! :) I've been testing for a...

> As I said I prefer the way crosvm did it - [#7292 (comment)](https://github.com/cloud-hypervisor/cloud-hypervisor/pull/7292#issuecomment-3487478530) > > i.e. you don't need separate write-zeroes option - we can just do that unconditionally...

> Right, crosvm does ZERO_RANGE by default for virtio WRITE_ZEROES. That's why i'm saying we don't need to have a special option for that. I agree, at least for my...