cabot icon indicating copy to clipboard operation
cabot copied to clipboard

Migrate Cabot to Python 3.6.5 and Django 3.2.5

Open Ladrusca opened this issue 3 years ago • 5 comments

Hi, I migrated Cabot to python 3 and it works! I also migrated the following plugins: -cabot-check-http -cabot-check-network -cabot-alert-slack -cabot-alert-email

Ladrusca avatar Aug 19 '21 20:08 Ladrusca

I love it. Let me review

dbuxton avatar Aug 20 '21 09:08 dbuxton

@Ladrusca @pablodgonzalez thanks for doing this. I'm going to carve out an hour to review this in the near future as I'd love to get merged. At the moment it's not super clear to me:

  • If there's major functionality that has been removed (e.g. REST API)
  • How to set up development
  • How to run tests
  • What modules work

Also if you can submit pull requests for the modules you've migrated that would be great.

dbuxton avatar Aug 25 '21 11:08 dbuxton

Hi @dbuxton I am writing previusly to @Ladrusca do that

We have removed all plugins logic in cabot, and create an repo index with all plugins we have found in pypi/github here https://github.com/senzil/cabot-plugins

In that way cabot is thiner and more customizable to each use case.

For now we publish a pypi package named cabot3, forked all plugins and change the dependency from cabot to cabot3, no for a definitive setup but just temporal while the main cabot repo and pypi package are updated.

Right now we are working in the new Docker image and use github actions (because delete travis and docker hub has not more automated builds)

The plan is get the image working well and then add test steps in github actions. Of course, the tests about plugins does not have sense anymore. Maybe, is possible add some dummies check and alert to test the models and logic of cabot and growth the coverage?

Our idea is you can check all and to make progressive pull request to each plugin (some of course are unmaintained and I think they goes to keep in that way but the are in the index anyway)

pablodgonzalez avatar Aug 25 '21 12:08 pablodgonzalez

Wow :)! Thanks for porting cabot to newer deps versions. Currently I have even trouble building the image. Hope the MR goes through review :)

paulkitt avatar Sep 13 '21 13:09 paulkitt

@dbuxton @Ladrusca is there any chance this PR will go through ? I am also having difficulty understanding the building and using the steps to have an updated cabot image. I was trying to follow through from the forked repo, even though the cabot image builds but the application does not start up complaining about the missing plugins, so I am not sure how the plugins are supposed to be integrated?

bbarman4u avatar Sep 04 '22 20:09 bbarman4u