trivy icon indicating copy to clipboard operation
trivy copied to clipboard

fix(helm): explicitly define `kind` and `apiVersion` of `volumeClaimTemplate` element

Open LucasVanHaaren opened this issue 6 months ago • 2 comments

Description

Hello, I made a quick fix to define explicitly all volumeClaimTemplate field. This allows to use gitops tools (like argoCD) to sync raw k8s manifests (built via helm) with cluster resources. Without these fields defined, these will be added in the cluster resource resulting in an OutOfSync with the generated manifest.

Feel free to discuss this fix in the below linked discussion.

Related issues

Like mentionned in guidelines for contributing, I think this change is trivial. This is why I created this PR without any Issue linked. Nevertheless, I oepened a discussion here: https://github.com/aquasecurity/trivy/discussions/7361

Checklist

  • [x] I've read the guidelines for contributing to this repository.
  • [x] I've followed the conventions in the PR title.
  • [x] I've added tests that prove my fix is effective or that my feature works.
  • [x] I've updated the documentation with the relevant information (if needed).
  • [x] I've added usage information (if the PR introduces new options)
  • [x] I've included a "before" and "after" example to the description (if the PR is a user interface change).

LucasVanHaaren avatar Aug 20 '24 13:08 LucasVanHaaren