trivy icon indicating copy to clipboard operation
trivy copied to clipboard

feat(license): add struct with types for licenses

Open DmitriyLewen opened this issue 2 years ago • 8 comments

Description

Add new License struct to exclude prefixes for licenses.

TODO:

  • add filePath for licenses (https://github.com/aquasecurity/trivy/discussions/6117#discussioncomment-8463597)

Related issues

  • Close #5204

Related PRs

  • [ ] aquasecurity/go-dep-parser/pull/256

Checklist

  • [x] I've read the guidelines for contributing to this repository.
  • [x] I've followed the conventions in the PR title.
  • [x] I've added tests that prove my fix is effective or that my feature works.
  • [ ] I've updated the documentation with the relevant information (if needed).
  • [ ] I've added usage information (if the PR introduces new options)
  • [ ] I've included a "before" and "after" example to the description (if the PR is a user interface change).

DmitriyLewen avatar Sep 19 '23 07:09 DmitriyLewen

@DmitriyLewen is this PR stale or do you intend to continue with it in the near future?

lior-orca avatar Oct 24 '23 10:10 lior-orca

Hello @lior-orca This PR is ready, but https://github.com/aquasecurity/go-dep-parser/pull/256 needs to be merged first.

DmitriyLewen avatar Oct 25 '23 02:10 DmitriyLewen

This PR is stale because it has been labeled with inactivity.

github-actions[bot] avatar Dec 25 '23 00:12 github-actions[bot]

Please check my comments in #5204

dus7eh avatar Feb 07 '24 20:02 dus7eh

Hello @DmitriyLewen I would like to ask is there any estimation when this can be delivered ? My team is strongly interested in ignoring python packages by their paths as it was discussed under: https://github.com/aquasecurity/trivy/discussions/6117. Thank you in advance, Regards Rafał :)

Rafcu90 avatar Feb 20 '24 10:02 Rafcu90

Hello @Rafcu90 Unfortunately, I can't give a time frame.

This PR changes base structure (I mean Package). The necessary time to review and test these changes. We've also combined go-dep-parser with Trivy. I need time to move https://github.com/aquasecurity/go-dep-parser/pull/256 to this PR.

DmitriyLewen avatar Feb 20 '24 10:02 DmitriyLewen

This PR is stale because it has been labeled with inactivity.

github-actions[bot] avatar Apr 21 '24 00:04 github-actions[bot]

This PR is stale because it has been labeled with inactivity.

github-actions[bot] avatar Jun 22 '24 00:06 github-actions[bot]