trivy icon indicating copy to clipboard operation
trivy copied to clipboard

refactor: remove parallel walk

Open knqyf263 opened this issue 1 year ago • 1 comments

Description

Since filepath.WalkDir is fast enough now, this PR removes github.com/saracen/walker. Also, it defines the Walker interface so that other tools can override the behavior.

Related issues

  • Close https://github.com/aquasecurity/trivy/issues/5179

Checklist

  • [x] I've read the guidelines for contributing to this repository.
  • [x] I've followed the conventions in the PR title.
  • [x] I've added tests that prove my fix is effective or that my feature works.
  • [ ] I've updated the documentation with the relevant information (if needed).
  • [ ] I've added usage information (if the PR introduces new options)
  • [ ] I've included a "before" and "after" example to the description (if the PR is a user interface change).

knqyf263 avatar Sep 13 '23 14:09 knqyf263

@santhosh1729 I think we'll merge this PR now, and you can give us feedback anytime.

knqyf263 avatar Jan 06 '24 07:01 knqyf263

This PR is stale because it has been labeled with inactivity.

github-actions[bot] avatar Apr 02 '24 00:04 github-actions[bot]

@DmitriyLewen Could you quickly take a look? Aqua confirmed it, and it should be fine, but I want to double-check it.

knqyf263 avatar Apr 16 '24 15:04 knqyf263