fix: migrate rbac k8s

Open chen-keinan opened this issue 3 years ago • 3 comments

Signed-off-by: chenk [email protected]

Description

fix: migrate rbac k8s scanner

Related PRs

DefSec 1111

Checklist

[x] I've read the guidelines for contributing to this repository.
[x] I've followed the conventions in the PR title.

Jan 19 '23 15:01 chen-keinan

@knqyf263 may be there is a flaky test , I do not see how this PR could impact it.

I open an issue to track it : #3463

Jan 19 '23 21:01 chen-keinan

@knqyf263 may be there is a flaky test , I do not see how this PR could impact it.

Looks like a flaky test. Just took a brief look at the test, seems like there's an address that's being compared (rather than value), which is probably causing the breakage.

Jan 19 '23 23:01 simar7

@knqyf263 may be there is a flaky test , I do not see how this PR could impact it.

Thanks for the catch. Fixed in https://github.com/aquasecurity/trivy/pull/3468

Jan 22 '23 12:01 knqyf263

@knqyf263 its ready for review , it was tested with this flag --skip-policy-update , without it, it doesn't work

Jan 24 '23 11:01 chen-keinan