trivy icon indicating copy to clipboard operation
trivy copied to clipboard

ci: auto generation configs for deb packages

Open afdesk opened this issue 3 years ago • 6 comments

Description

Added auto generation conf/distributions for building deb packages.

Related issues

  • Close #1692
  • the first PR #1775

Checklist

  • [x] I've read the guidelines for contributing to this repository.
  • [x] I've followed the conventions in the PR title.
  • [ ] I've added tests that prove my fix is effective or that my feature works.
  • [ ] I've updated the documentation with the relevant information (if needed).
  • [ ] I've added usage information (if the PR introduces new options)
  • [ ] I've included a "before" and "after" example to the description (if the PR is a user interface change).

afdesk avatar Jun 24 '22 13:06 afdesk

Oh, I might be missing something. Don't we remove old releases?

https://github.com/aquasecurity/trivy/blob/1b4d38629c642117fb6801aeaa1c7d3b6b2d6a27/ci/deploy-deb.sh#L10-L12

For example, what happens to Debian 8 after it reaches EOL? I wanted to keep the binary for Debian 8.

if i understand correctly, this script removes only supported version for update: https://github.com/aquasecurity/trivy/blob/1b4d38629c642117fb6801aeaa1c7d3b6b2d6a27/ci/deploy-deb.sh#L3-L13

afdesk avatar Jun 27 '22 13:06 afdesk

or i missed something now

afdesk avatar Jun 27 '22 13:06 afdesk

Seems like so. You can revert a commit with --all. I'm sorry for my bad. I misunderstood all releases were removed.

knqyf263 avatar Jun 29 '22 08:06 knqyf263

maybe i miss something, the my idea was about generation distributions file automatically and so we should build it with --all flag. now this file is static: https://github.com/aquasecurity/trivy-repo/blob/main/deb/conf/distributions we don't change the rest of the script, right?

afdesk avatar Jul 01 '22 11:07 afdesk

@knqyf263 or do you mean that we should rebuild trivy for all distros (including unsupported)?

afdesk avatar Jul 08 '22 12:07 afdesk

This PR is stale because it has been labeled with inactivity.

github-actions[bot] avatar Sep 07 '22 00:09 github-actions[bot]