trivy icon indicating copy to clipboard operation
trivy copied to clipboard

Re-add Windows binary to releases.

Open Johannestegner opened this issue 2 years ago • 2 comments

Hi!

There are a few of us developers who uses windows (it's true!), and having trivy binary directly on windows is quite nice, especially after the new jetbrains plugin have been created! I understand that it was removed earlier due to some stuff not working as expected (image scanning for example), but by building it locally

(in wsl ubuntu)

GOARCH=amd64 GOOS=windows go build -o trivy.exe cmd/trivy/main.go

I could produce a binary which works fine (even the image scanning tool).

Is there any currently known issue which hinders a windows binary to be added to the release scripts or should I create a PR to re-add it to them? If there is no wish to have windows binaries at all, I'm totally fine with that as well, building it from source is not a huge deal either way! :)

Johannestegner avatar Apr 27 '22 08:04 Johannestegner

related PR #1469

itaysk avatar Jun 07 '22 08:06 itaysk

FYI. I replaced #1469 with #2592 and included test binary to there. It would be nice if others can also test and report results to that PR as it looks to be that Trivy maintainers are Linux only users and are not able to test.

olljanat avatar Jul 26 '22 10:07 olljanat

Hello @olljanat , @owenrumney

User found problem with table report in Windows(#3039). Can you include fix for it in PR?

Regards, Dmitriy

DmitriyLewen avatar Oct 21 '22 02:10 DmitriyLewen

+1 on brining this back

tomkerkhove avatar Nov 23 '22 07:11 tomkerkhove

we're looking into this in https://github.com/aquasecurity/trivy/pull/3037. not sure it will be merged for this month's release though.

itaysk avatar Nov 23 '22 12:11 itaysk

The next release will distribute Windows binaries.

knqyf263 avatar Dec 26 '22 09:12 knqyf263