trivy-operator icon indicating copy to clipboard operation
trivy-operator copied to clipboard

Have only one source of configuration

Open josedonizetti opened this issue 2 years ago • 3 comments

Currently, there is two separate ways to configure trivy-operator settings. There are settings configured as environment variables to the deployment, and some other options configured in a configmap. This leads to complexity in code, for example, all controllers receive etc.Config and also trivyoperator.ConfigData which represent the different way of configuring trivy-operator. Also, from a UX point, it is preferable to change configurations on a configmap then restart the pod, simpler than changing an env var on a deployment.

josedonizetti avatar Aug 10 '22 00:08 josedonizetti

@chen-keinan Do you mind if I take this issue?

josedonizetti avatar Aug 22 '22 19:08 josedonizetti

@josedonizetti thanks for picking this up! This would be a very nice improvement!

JAORMX avatar Aug 26 '22 06:08 JAORMX

@josedonizetti was the mentioned pull request pending more development or pending review when it was closed for being stale?

jrhunger avatar Dec 13 '22 17:12 jrhunger