trivy-operator icon indicating copy to clipboard operation
trivy-operator copied to clipboard

How to update serviceMonitorSelectorNilUsesHelm values when using OpenShift Prometheus Operators is used

Open chen-keinan opened this issue 1 year ago • 8 comments

Discussed in https://github.com/aquasecurity/trivy-operator/discussions/1329

Originally posted by ajay15283 June 27, 2023 If prometheus is not installed from kube-prometheus-stack and instead openshift promethus operators were used in that case how to update serviceMonitorSelectorNilUsesHelmValues to false as the metrics are not visible in grafana dashboard

From Documentation Our Prometheus installation needs to be slightly customised to discover ServiceMonitors by default. Create a values.yaml file with the following configuration:

prometheus: prometheusSpec: serviceMonitorSelectorNilUsesHelmValues: true serviceMonitorSelector: {} serviceMonitorNamespaceSelector: {}

chen-keinan avatar Jun 27 '23 07:06 chen-keinan

@ajay15283 the requirements sound reasonable , feel free to pick it up

chen-keinan avatar Jun 27 '23 07:06 chen-keinan

Hi @chen-keinan Could you please assign this issue to me.

geoffrey1330 avatar Nov 22 '23 10:11 geoffrey1330

@ajay15283 if am to get you right. you want the installation process for prometheus in the docs to highlight the configurations when using either kube-prometheus-stack or openshift promethus operators?

geoffrey1330 avatar Nov 27 '23 09:11 geoffrey1330

@geoffrey1330 , yes the document is clear if the prometheus is installed from kube-prometheus-stack and have no specific information for prometheus installed from other options especially if its installed as an operator

ajay15283 avatar Nov 27 '23 10:11 ajay15283

Alright

geoffrey1330 avatar Nov 27 '23 10:11 geoffrey1330

Hi @ajay15283 it seems like the process of installing prometheus via prometheus-operator is no longer supported as stated here they suggested everyone should make use of the prometheus-community/kube-prometheus-stack as it has been moved there

geoffrey1330 avatar Nov 27 '23 10:11 geoffrey1330

could you please move to the supported approach and close the issue.

geoffrey1330 avatar Nov 27 '23 10:11 geoffrey1330